Issue 5633 - Removed patterned background-images

Issue 5633 - Removed patterned background-images

[ire, 2017-09-21 08:33:50]

Thanks Julian!

Quick question, do you plan to push this live in it's current state? I think the
plain white background looks a bit weird (maybe the beige colour would have been
better?). This is probably more a product question I acknowledge.

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/main.css
File static/css/main.css (left):

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/main.css...
static/css/main.css:10: background-image: url(../img/background.png);
The background.png file isn't being used anywhere, so should be removed.

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/simple.css
File static/css/simple.css (left):

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/simple.c...
static/css/simple.css:124: background-image: url(/img/background-blue.png);
Same with this image

[juliandoucette, 2017-09-21 14:47:08]

> Quick question, do you plan to push this live in it's current state? I think
the plain white background looks a bit weird (maybe the beige colour would have
been better?). This is probably more a product question I acknowledge.

I will push it to a separate branch with the rest of
https://issues.adblockplus.org/milestone/adblockplus.org%201.1.0 and release
everything at once after testing.

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/main.css
File static/css/main.css (left):

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/main.css...
static/css/main.css:10: background-image: url(../img/background.png);
On 2017/09/21 08:33:49, ire wrote:
> The background.png file isn't being used anywhere, so should be removed.

Acknowledged.

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/simple.css
File static/css/simple.css (left):

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/simple.c...
static/css/simple.css:124: background-image: url(/img/background-blue.png);
On 2017/09/21 08:33:49, ire wrote:
> Same with this image

Acknowledged.

[juliandoucette, 2017-09-21 14:49:45]

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/main.css
File static/css/main.css (left):

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/main.css...
static/css/main.css:10: background-image: url(../img/background.png);
On 2017/09/21 08:33:49, ire wrote:
> The background.png file isn't being used anywhere, so should be removed.

Done.

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/simple.css
File static/css/simple.css (left):

https://codereview.adblockplus.org/29550786/diff/29550787/static/css/simple.c...
static/css/simple.css:124: background-image: url(/img/background-blue.png);
On 2017/09/21 08:33:49, ire wrote:
> Same with this image

Done.

[ire, 2017-09-21 16:24:07]

On 2017/09/21 14:47:08, juliandoucette wrote:
> > Quick question, do you plan to push this live in it's current state? I think
> the plain white background looks a bit weird (maybe the beige colour would
have
> been better?). This is probably more a product question I acknowledge.
> 
> I will push it to a separate branch with the rest of
> https://issues.adblockplus.org/milestone/adblockplus.org%201.1.0 and release
> everything at once after testing.

Thanks!

LGTM

[juliandoucette, 2017-09-25 14:38:06]

Done
https://bitbucket.org/adblockplus/adblockplus.org/commits/2598dfba2c13f67e5a1....