Issue 29550790: Issue 268 - Remove empty.css hack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29550790: Issue 268 - Remove empty.css hack (Closed)

Created:
Sept. 20, 2017, 4:23 p.m. by juliandoucette

Modified:
Sept. 21, 2017, 4:24 p.m.

Reviewers:
ire

Base URL:
https://hg.adblockplus.org/web.adblockplus.org

Visibility:
Public.

Description

Note: This change is low priority and requires IE 8 testing. I think that we can just remove this and nothing significant will break.

Patch Set 1 #

Created: Sept. 20, 2017, 4:23 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -5 lines)			Patch
	R	static/css/empty.css	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	templates/default.tmpl	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ire

> Note: This change is low priority and requires IE 8 testing. I think that ...

Sept. 21, 2017, 8:38 a.m. (2017-09-21 08:38:37 UTC) #2

ire

Also, the issue still states that cssfx.js should be deferred loading, not removed. Could you ...

Sept. 21, 2017, 8:40 a.m. (2017-09-21 08:40:24 UTC) #3

juliandoucette

This was unclear :( I'll test myself, update the ticket, and upload a separate review.

Sept. 21, 2017, 2:41 p.m. (2017-09-21 14:41:42 UTC) #4

ire

Sept. 21, 2017, 4:24 p.m. (2017-09-21 16:24:47 UTC) #5

Message was sent while issue was closed.

On 2017/09/21 14:41:42, juliandoucette wrote:
> This was unclear :( 
> 
> I'll test myself, update the ticket, and upload a separate review.

No worries! Thank you :)

Expand All Messages | Collapse All Messages