Delta Between Two Patch Sets: scss/_content.scss
Issue 29551691:
Noissue - Make website-default headings bold (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set:
Created Sept. 21, 2017, 4:47 p.m.
Right Patch Set: Replaced bold with -weight
Created Sept. 22, 2017, 11:38 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 /*! | 1 /*! |
| 2 * This file is part of website-defaults | 2 * This file is part of website-defaults |
| 3 * Copyright (C) 2016-present eyeo GmbH | 3 * Copyright (C) 2016-present eyeo GmbH |
| 4 * | 4 * |
| 5 * website-defaults is free software: you can redistribute it and/or | 5 * website-defaults is free software: you can redistribute it and/or |
| 6 * modify it under the terms of the GNU General Public License as published by | 6 * modify it under the terms of the GNU General Public License as published by |
| 7 * the Free Software Foundation, either version 3 of the License, or | 7 * the Free Software Foundation, either version 3 of the License, or |
| 8 * (at your option) any later version. | 8 * (at your option) any later version. |
| 9 * | 9 * |
| 10 * website-defaults is distributed in the hope that it will be useful, | 10 * website-defaults is distributed in the hope that it will be useful, |
| (...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 47 h1, | 47 h1, |
| 48 h2, | 48 h2, |
| 49 h3, | 49 h3, |
| 50 h4, | 50 h4, |
| 51 h5, | 51 h5, |
| 52 h6 | 52 h6 |
| 53 { | 53 { |
| 54 /* Margin on top **only** (opinionated) */ | 54 /* Margin on top **only** (opinionated) */ |
| 55 margin: 2em 0em 0.5em 0em; | 55 margin: 2em 0em 0.5em 0em; |
| 56 /* All headings should be bold (opinionated) */ | 56 /* All headings should be bold (opinionated) */ |
| 57 font-weight: bold; | 57 font-weight: $bold-weight; |
|
ire
2017/09/22 08:33:29
Why didn't you use the $bold-weight variable?
juliandoucette
2017/09/22 11:36:32
I forgot about it.
Good catch.
juliandoucette
2017/09/22 11:38:30
Done.
| |
| 58 } | 58 } |
| 59 | 59 |
| 60 h1 | 60 h1 |
| 61 { | 61 { |
| 62 font-size: 2em; | 62 font-size: 2em; |
| 63 } | 63 } |
| 64 | 64 |
| 65 h2 | 65 h2 |
| 66 { | 66 { |
| 67 font-size: 1.5em; | 67 font-size: 1.5em; |
| (...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 161 { | 161 { |
| 162 /* undo browser default (opinionated)*/ | 162 /* undo browser default (opinionated)*/ |
| 163 font-weight: $bold-weight; | 163 font-weight: $bold-weight; |
| 164 } | 164 } |
| 165 | 165 |
| 166 dd | 166 dd |
| 167 { | 167 { |
| 168 margin: 0.25em 0em 1em 0em; | 168 margin: 0.25em 0em 1em 0em; |
| 169 } | 169 } |
| 170 } | 170 } |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
