Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29551691: Noissue - Make website-default headings bold (Closed)

Created:
Sept. 21, 2017, 4:47 p.m. by juliandoucette
Modified:
Sept. 22, 2017, 6:16 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Noissue - Make website-default headings bold

Patch Set 1 #

Total comments: 3

Patch Set 2 : Replaced bold with -weight #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M scss/_content.scss View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
juliandoucette
Sept. 21, 2017, 4:47 p.m. (2017-09-21 16:47:33 UTC) #1
ire
https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss File scss/_content.scss (right): https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss#newcode57 scss/_content.scss:57: font-weight: bold; Why didn't you use the $bold-weight variable?
Sept. 22, 2017, 8:33 a.m. (2017-09-22 08:33:29 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss File scss/_content.scss (right): https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss#newcode57 scss/_content.scss:57: font-weight: bold; On 2017/09/22 08:33:29, ire wrote: > Why ...
Sept. 22, 2017, 11:36 a.m. (2017-09-22 11:36:32 UTC) #3
juliandoucette
https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss File scss/_content.scss (right): https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss#newcode57 scss/_content.scss:57: font-weight: bold; On 2017/09/22 08:33:29, ire wrote: > Why ...
Sept. 22, 2017, 11:38 a.m. (2017-09-22 11:38:30 UTC) #4
ire
On 2017/09/22 11:38:30, juliandoucette wrote: > https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss > File scss/_content.scss (right): > > https://codereview.adblockplus.org/29551691/diff/29551692/scss/_content.scss#newcode57 > ...
Sept. 22, 2017, 11:50 a.m. (2017-09-22 11:50:29 UTC) #5
juliandoucette
Sept. 22, 2017, 6:15 p.m. (2017-09-22 18:15:57 UTC) #6

Powered by Google App Engine
This is Rietveld