Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29551734: Issue 5634 - Removed locale flags from abp.org header (Closed)

Created:
Sept. 21, 2017, 11:02 p.m. by juliandoucette
Modified:
Sept. 25, 2017, 2:51 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5634 - Removed locale flags from abp.org header

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M static/css/main.css View 1 chunk +2 lines, -14 lines 0 comments Download
M templates/default.tmpl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7
juliandoucette
Sept. 21, 2017, 11:02 p.m. (2017-09-21 23:02:12 UTC) #1
juliandoucette
On 2017/09/21 23:02:12, juliandoucette wrote: (I'll remove the flags all-together in the footer implementation.)
Sept. 21, 2017, 11:07 p.m. (2017-09-21 23:07:14 UTC) #2
ire
Will you make this more semantic and have appropriate keyboard support etc in a separate ...
Sept. 22, 2017, 9:01 a.m. (2017-09-22 09:01:48 UTC) #3
juliandoucette
On 2017/09/22 09:01:48, ire wrote: > Will you make this more semantic and have appropriate ...
Sept. 22, 2017, 11:44 a.m. (2017-09-22 11:44:44 UTC) #4
juliandoucette
On 2017/09/22 11:44:44, juliandoucette wrote: > Yes. See https://issues.adblockplus.org/ticket/5753. (Dropdown/Menu will be part of this ...
Sept. 22, 2017, 11:45 a.m. (2017-09-22 11:45:37 UTC) #5
ire
On 2017/09/22 11:45:37, juliandoucette wrote: > On 2017/09/22 11:44:44, juliandoucette wrote: > > Yes. See ...
Sept. 22, 2017, 11:49 a.m. (2017-09-22 11:49:55 UTC) #6
juliandoucette
Sept. 25, 2017, 2:49 p.m. (2017-09-25 14:49:31 UTC) #7

Powered by Google App Engine
This is Rietveld