Issue 5698 - Update V8 to 6.1.534.41

No changes in the code are required, however the building of V8 is not so straightforward anymore.
- add `/bigobj` compiler flag for Visual C++ ''Debug|x64''
- to simplify the things, the everything related to recently added inspector is removed from `third_party/v8/src/v8.gyp`. v8.gyp started to include inspector, which is BTW not used by us, and which causes some building errors with the current approach, e.g. even after fixing path expansion in gyp it cannot be built by msbuild and requires devenv but in this case we have to build more projects and satisfy more requirements or modify generated solution files or do something else. The easiest way is to remove this dependency what simplifies and speeds up the building process.

[sergei, 2017-09-25 09:27:40]

https://codereview.adblockplus.org/29555620/diff/29555621/build-v8-patch-v8.g...
File build-v8-patch-v8.gyp.py (right):

https://codereview.adblockplus.org/29555620/diff/29555621/build-v8-patch-v8.g...
build-v8-patch-v8.gyp.py:1: #!/usr/bin/env python
I actually find this approach with manual patching at least not elegant because
it's based not on unidiff, perhaps it would be better for instance to make the
changes in our mirror of V8 repo. BTW, I have not chosen the latter because the
support of such changes is not very transparent and I guess it will complicate
the way of trying a new version of V8, because our git and hg repositories of V8
are not automatically synchronized.
Anyway I think it should not be a stopper of the issue, so if there is no
something really critical I would propose to postpone any questionable parts and
do them in https://issues.adblockplus.org/ticket/5503.

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode1
dependencies:1: _root = hg:https://hg.adblockplus.org/
git:https://github.com/adblockplus/
Git revisions are from
https://github.com/adblockplus/v8-googlesource/blob/f29d55e61904333f3ccc79202...

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode7
dependencies:7: third_party/v8 = v8-googlesource hg:325b859d0fd8
git:f29d55e61904333f3ccc792021885dfa8dc980e2
https://hg.adblockplus.org/v8-googlesource/rev/325b859d0fd8
https://github.com/adblockplus/v8-googlesource/commit/f29d55e61904333f3ccc792...

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode8
dependencies:8: third_party/v8/base/trace_event/common =
chromium-trace_event-common hg:23ca1cb1bb90
git:65d1d42a5df6c0a563a6fdfa58a135679185e5d9
https://hg.adblockplus.org/chromium-trace_event-common/rev/23ca1cb1bb90
https://github.com/adblockplus/chromium-trace_event-common/commit/65d1d42a5d

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode9
dependencies:9: third_party/v8/build = chromium-src-build hg:9cbbad34638b
git:1808a907ce42f13b224c263e9843d718fc6d9c39
https://hg.adblockplus.org/chromium-src-build/rev/9cbbad34638b
https://github.com/adblockplus/chromium-src-build/commit/1808a907ce42f13b224c...

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode11
dependencies:11: third_party/v8/tools/gyp = gyp hg:94c61f14b4e6
git:eb296f67da078ec01f5e3a9ea9cdc6d26d680161
https://hg.adblockplus.org/gyp/rev/94c61f14b4e6
https://github.com/adblockplus/gyp/commit/eb296f67da078ec01f5e3a9ea9cdc6d26d6...

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode12
dependencies:12: third_party/v8/tools/clang = chromium-src-tools-clang
hg:057a211296cf git:844603c1fcd47f578931b3ccd583e19f816a3842
https://hg.adblockplus.org/chromium-src-tools-clang/rev/057a211296cf
https://github.com/adblockplus/chromium-src-tools-clang/commit/844603c1fcd47f...

https://codereview.adblockplus.org/29555620/diff/29555621/dependencies#newcode13
dependencies:13: third_party/v8/third_party/icu = chromium-deps-icu
hg:da2e19dff3f2 git:dfa798fe694702b43a3debc3290761f22b1acaf8
https://hg.adblockplus.org/chromium-deps-icu/rev/da2e19dff3f2
https://github.com/adblockplus/chromium-deps-icu/commit/dfa798fe694702b43a3de...

[hub, 2017-09-25 15:22:39]

After I do a "make" if I run "make test" I get an error:

python ensure_dependencies.py
INFO: Updating repository third_party/v8 to revision 325b859d0fd8
abort: uncommitted changes

This is because we change a file in v8 and it stay as uncommitted and
ensure_depenedencies.py doesn't like that.

[sergei, 2017-09-26 14:34:38]

On 2017/09/25 15:22:39, hub wrote:
> After I do a "make" if I run "make test" I get an error:
> 
> python ensure_dependencies.py
> INFO: Updating repository third_party/v8 to revision 325b859d0fd8
> abort: uncommitted changes
> 
> This is because we change a file in v8 and it stay as uncommitted and
> ensure_depenedencies.py doesn't like that.

Yeah, I see the issue.
I'm going to have a commit in our V8-mirror, so could you please let me know if
you have something better. BTW, we use the same approach with gyp right now, so
it should be fine, however it subtly differs and therefore, beside addition
actions, I don't like this hidden knowledge.

[hub, 2017-09-26 22:02:45]

On 2017/09/26 14:34:38, sergei wrote:
 
> Yeah, I see the issue.
> I'm going to have a commit in our V8-mirror, so could you please let me know
if
> you have something better. BTW, we use the same approach with gyp right now,
so
> it should be fine, however it subtly differs and therefore, beside addition
> actions, I don't like this hidden knowledge.

Seems like a reasonable tradeoff. Having to patch upstream is always a nuisance.

[sergei, 2017-09-28 07:36:38]

https://codereview.adblockplus.org/29555620/diff/29558555/.travis.yml
File .travis.yml (right):

https://codereview.adblockplus.org/29555620/diff/29558555/.travis.yml#newcode25
.travis.yml:25: -
URL_PREFIX=https://v8.eyeofiles.com/v8-9a4991959e231351e52266b631cbd36f8341bdc3/
Currently it's V8 commit, originally I wanted to have here a commit of the repo
which is used to build V8 because it contains an actually used configuration.
However, while there is no libadblockplus-v8 repository
https://issues.adblockplus.org/ticket/5503, one cannot put a commit ID here
because of a vicious circle. The commit, which ID should be put here, contains
the change itself, but its hash (ID) depends on the change which unknown yet.
In order to track the origin of the source there is `info`
(https://v8.eyeofiles.com/v8-9a4991959e231351e52266b631cbd36f8341bdc3/info) file
on the server. BTW, for previous version there is also info file but it differs.

https://codereview.adblockplus.org/29555620/diff/29558555/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29555620/diff/29558555/dependencies#newcode7
dependencies:7: third_party/v8 = v8-googlesource hg:3f696d7a8e86
git:9a4991959e231351e52266b631cbd36f8341bdc3
I have not pushed the changes yet to adblockplus/v8-googlesource repositories, I
plan to do it right before pushing the changes from this codereview because I
think they should be reviewed and I would propose to do it in this codereview,
https://codereview.adblockplus.org/29558562/.

https://codereview.adblockplus.org/29555620/diff/29558555/make_gyp_wrapper.py
File make_gyp_wrapper.py (left):

https://codereview.adblockplus.org/29555620/diff/29558555/make_gyp_wrapper.py...
make_gyp_wrapper.py:122: # Issue 5393
It's fixed in v8.gyp, see the change of the order of library dependencies for
mksnapshot.

[sergei, 2017-09-28 15:53:19]

https://codereview.adblockplus.org/29555620/diff/29558555/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29555620/diff/29558555/dependencies#newcode7
dependencies:7: third_party/v8 = v8-googlesource hg:3f696d7a8e86
git:9a4991959e231351e52266b631cbd36f8341bdc3
Pushed.
https://hg.adblockplus.org/v8-googlesource/rev/3f696d7a8e86
https://github.com/adblockplus/v8-googlesource/commit/9a4991959e231351e52266b...

[hub, 2017-09-28 19:38:54]

LGTM