Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 29555620: Issue 5698 - Update V8 to 6.1.534.41 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by sergei
Modified:
2 years, 4 months ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

No changes in the code are required, however the building of V8 is not so straightforward anymore. - add `/bigobj` compiler flag for Visual C++ ''Debug|x64'' - to simplify the things, the everything related to recently added inspector is removed from `third_party/v8/src/v8.gyp`. v8.gyp started to include inspector, which is BTW not used by us, and which causes some building errors with the current approach, e.g. even after fixing path expansion in gyp it cannot be built by msbuild and requires devenv but in this case we have to build more projects and satisfy more requirements or modify generated solution files or do something else. The easiest way is to remove this dependency what simplifies and speeds up the building process.

Patch Set 1 #

Total comments: 8

Patch Set 2 : fix and rebase #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M .travis.yml View 1 1 chunk +1 line, -1 line 1 comment Download
M appveyor.yml View 1 1 chunk +1 line, -1 line 0 comments Download
M build-v8.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
M dependencies View 1 1 chunk +6 lines, -6 lines 2 comments Download
M make_gyp_wrapper.py View 1 1 chunk +0 lines, -10 lines 1 comment Download
M msvs_gyp_wrapper.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
sergei
https://codereview.adblockplus.org/29555620/diff/29555621/build-v8-patch-v8.gyp.py File build-v8-patch-v8.gyp.py (right): https://codereview.adblockplus.org/29555620/diff/29555621/build-v8-patch-v8.gyp.py#newcode1 build-v8-patch-v8.gyp.py:1: #!/usr/bin/env python I actually find this approach with manual ...
2 years, 4 months ago (2017-09-25 09:27:40 UTC) #1
hub
After I do a "make" if I run "make test" I get an error: python ...
2 years, 4 months ago (2017-09-25 15:22:39 UTC) #2
sergei
On 2017/09/25 15:22:39, hub wrote: > After I do a "make" if I run "make ...
2 years, 4 months ago (2017-09-26 14:34:38 UTC) #3
hub
On 2017/09/26 14:34:38, sergei wrote: > Yeah, I see the issue. > I'm going to ...
2 years, 4 months ago (2017-09-26 22:02:45 UTC) #4
sergei
https://codereview.adblockplus.org/29555620/diff/29558555/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29555620/diff/29558555/.travis.yml#newcode25 .travis.yml:25: - URL_PREFIX=https://v8.eyeofiles.com/v8-9a4991959e231351e52266b631cbd36f8341bdc3/ Currently it's V8 commit, originally I wanted ...
2 years, 4 months ago (2017-09-28 07:36:38 UTC) #5
sergei
https://codereview.adblockplus.org/29555620/diff/29558555/dependencies File dependencies (right): https://codereview.adblockplus.org/29555620/diff/29558555/dependencies#newcode7 dependencies:7: third_party/v8 = v8-googlesource hg:3f696d7a8e86 git:9a4991959e231351e52266b631cbd36f8341bdc3 Pushed. https://hg.adblockplus.org/v8-googlesource/rev/3f696d7a8e86 https://github.com/adblockplus/v8-googlesource/commit/9a4991959e231351e52266b631cbd36f8341bdc3
2 years, 4 months ago (2017-09-28 15:53:19 UTC) #6
hub
2 years, 4 months ago (2017-09-28 19:38:54 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5