Issue 29555660: Issue 5769 - Worked around bad Firefox 55 storage performance

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29555660: Issue 5769 - Worked around bad Firefox 55 storage performance (Closed)

Created:
Sept. 25, 2017, 10:38 a.m. by Wladimir Palant

Modified:
Sept. 25, 2017, 11:09 a.m.

Reviewers:
kzar

CC:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluschrome

Visibility:
Public.

Description

I verified that rewriting storage is delayed on Firefox, yet the value is stored immediately on Chrome. So we have a short window where data loss could happen on Firefox, this shouldn`t be a big issue however.

Patch Set 1 #

Created: Sept. 25, 2017, 10:38 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
	M	lib/prefs.js	View		2 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

I wonder if we should only throttle saving of the ads counter, instead of all ...

Sept. 25, 2017, 10:47 a.m. (2017-09-25 10:47:54 UTC) #2

Wladimir Palant

On 2017/09/25 10:47:54, kzar wrote: > I wonder if we should only throttle saving of ...

Sept. 25, 2017, 10:49 a.m. (2017-09-25 10:49:54 UTC) #3

kzar

Sept. 25, 2017, 11 a.m. (2017-09-25 11:00:47 UTC) #4

On 2017/09/25 10:49:54, Wladimir Palant wrote:
> On 2017/09/25 10:47:54, kzar wrote:
> > I wonder if we should only throttle saving of the ads counter, instead of
all
> > prefs?
> 
> All other prefs are actual prefs - they are changed by the user. So these
don't
> change frequently, and data loss is also less acceptable.

Ah then we agree. (Sorry I hadn't properly looked through the changes when I
said that and had assumed you were just throttling saves for all prefs.)

LGTM

Expand All Messages | Collapse All Messages