Issue 29555778: Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29555778: Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a (Closed)

Created:
Sept. 25, 2017, 3:24 p.m. by Sebastian Noack

Modified:
Sept. 28, 2017, 9:31 p.m.

Reviewers:
Manish Jethani, kzar

Visibility:
Public.

Description

Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a

Patch Set 1 : #

Patch Set 2 : Include latest core changes #

Created: Sept. 27, 2017, 9:19 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -112 lines)			Patch
M	dependencies	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include.preload.js	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	lib/compat.js	View		3 chunks	+16 lines, -106 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Sebastian Noack

I updated the patch (and the issue) to also account for the the latest changes ...

Sept. 27, 2017, 9:23 p.m. (2017-09-27 21:23:20 UTC) #2

Manish Jethani

On 2017/09/28 11:03:48, Manish Jethani wrote: > LGTM I found a reference to nsIFile in ...

Sept. 28, 2017, 11:05 a.m. (2017-09-28 11:05:30 UTC) #5

Sebastian Noack

Sept. 28, 2017, 9:29 p.m. (2017-09-28 21:29:10 UTC) #6

On 2017/09/28 11:05:30, Manish Jethani wrote:
> I found a reference to nsIFile in the adblockpluscore comments that is
probably
> outdated:
> 
>
https://hg.adblockplus.org/adblockpluscore/file/d4ed3916793a/lib/filterStorag...

It seems so. This jsdoc comment defines FileInfo with a property of the type
nsIFile. The function below is documented to return a Promise that resolves to
an array of FileInfo, which is the only reference to FileInfo in this file.
However, it is obvious, by looking at the code, that the return value of that
function rather looks like [{index, lastModified}]. So yeah, the jsdoc comments
are outdated there.

Expand All Messages | Collapse All Messages