libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java - Issue 29556582: Issue 5643 - Make v8::Isolate injectable into JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

Issue 29556582: Issue 5643 - Make v8::Isolate injectable into JsEngine (Closed)

Patch Set: Created Sept. 26, 2017, 8:54 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java ('K') | « libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

index f7d2ec6e40ff4e783aeda8515d9c0337fc1953a6..5eea26ca0cb92d35194cec3e5a2a48450747aa76 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

@@ -133,6 +133,7 @@ public final class AdblockEngine

private AppInfo appInfo;

private String basePath;

private IsAllowedConnectionCallback isAllowedConnectionCallback;

+ private Long v8IsolatePtr;

private AdblockEngine engine;

@@ -169,6 +170,12 @@ public final class AdblockEngine

return this;

}

+ public Builder useV8Isolate(long v8IsolatePtr)

+ {

+ this.v8IsolatePtr = v8IsolatePtr;

+ return this;

+ }

public Builder setUpdateAvailableCallback(UpdateAvailableCallback callback)

{

engine.updateAvailableCallback = callback;

@@ -255,7 +262,7 @@ public final class AdblockEngine

{

engine.logSystem = new AndroidLogSystem();

engine.platform = new Platform(engine.logSystem, engine.webRequest, basePath);

- engine.platform.setUpJsEngine(appInfo);

+ engine.platform.setUpJsEngine(appInfo, v8IsolatePtr);

engine.platform.setUpFilterEngine(isAllowedConnectionCallback);

engine.filterEngine = engine.platform.getFilterEngine();

}