Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: new-options.html

Issue 29556681: Issue 5779 - Missing checkbox in language dialog and persistent validation (Closed)
Patch Set: Created Sept. 26, 2017, 6:33 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | new-options.js » ('j') | skin/new-options.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: new-options.html
===================================================================
--- a/new-options.html
+++ b/new-options.html
@@ -347,12 +347,12 @@
<p class="i18n_options_dialog_about_copyright"></p>
<p class="i18n_options_dialog_about_trademark"></p>
<p>
- <button class="i18n_options_close primary" data-action="close-dialog"></button>
+ <button class="i18n_options_close primary default-focus" data-action="close-dialog"></button>
saroyanm 2017/09/26 18:40:52 This dialogs were missing default focus, I thought
ire 2017/09/28 07:33:44 Acknowledged.
</p>
</div>
<!-- Add language subscription -->
<div id="dialog-content-language-add" class="dialog-content">
- <ul id="all-lang-table-add" class="table list">
+ <ul id="all-lang-table-add" class="table list default-focus">
<template>
<button data-action="add-language-subscription,close-dialog" class="control add" role="checkbox">
<label class="display"></label>
@@ -373,7 +373,7 @@
<span class="i18n_options_dialog_import_subscription_title_error error-msg"></span>
</p>
<p class="floating-input">
- <input placeholder=" " id="import-list-url" type="url" class="default-focus" required/>
+ <input placeholder=" " id="import-list-url" type="url" required/>
<label for="import-list-url" class="i18n_options_dialog_import_subscription_location"></label>
<span class="attention"></span>
<span class="i18n_options_dialog_import_subscription_location_error error-msg"></span>
« no previous file with comments | « no previous file | new-options.js » ('j') | skin/new-options.css » ('J')

Powered by Google App Engine
This is Rietveld