Unified Diff: new-options.js
Issue 29556681:
Issue 5779 - Missing checkbox in language dialog and persistent validation (Closed)
Patch Set:
Created Sept. 26, 2017, 6:33 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« new-options.html ('K')
|
« new-options.html ('k')
|
skin/new-options.css » ('j')
|
skin/new-options.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.js |
| =================================================================== |
| --- a/new-options.js |
| +++ b/new-options.js |
| @@ -223,8 +223,8 @@ |
| element.setAttribute("aria-label", title); |
| if (this.details[i].searchable) |
| element.setAttribute("data-search", title.toLowerCase()); |
| - let control = element.querySelector(".control[role='checkbox']"); |
| - if (control) |
| + let controls = element.querySelectorAll(".control[role='checkbox']"); |
| + for (let control of controls) |
| { |
| control.setAttribute("aria-checked", item.disabled == false); |
| if (isAcceptableAds(item.url) && this == collections.filterLists) |
« new-options.html ('K')
|
« new-options.html ('k')
|
skin/new-options.css » ('j')
|
skin/new-options.css » ('J')
