mozharness/abb/transform_locales.py - Issue 29556775: Issue 5518 - Add Ecosia as secondary search engine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: mozharness/abb/transform_locales.py

Issue 29556775: Issue 5518 - Add Ecosia as secondary search engine (Closed)

Patch Set: Including requested changes for ecosia search plugin xml Created Oct. 3, 2017, 9:37 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: mozharness/abb/transform_locales.py

===================================================================

--- a/mozharness/abb/transform_locales.py

+++ b/mozharness/abb/transform_locales.py

@@ -201,18 +201,18 @@ def _transform_locale(locale, path, logg

if len(engine_ids) == 0:

logger.fatal("No search engines left over for '%s'" % locale)

# 'Parse' XML to get matching 'ShortName' for all engine IDs

engine_names = {}

for eid in engine_ids[:]:

xml_file_path = os.path.join(path, _SEARCHPLUGINS_PATH, "%s.xml" % eid)

if not os.path.exists(xml_file_path):

- logger.info("Missing xml file for plugin %s. Searched in path %s"

- % eid, xml_file_path)

+ logger.info("Missing xml file for plugin %s. Searched in path %s" %

+ (eid, xml_file_path))

engine_ids.remove(eid)

continue

short_name = None

with open(xml_file_path, "r") as fd:

for line in fd:

line = line.strip()

match = _SHORTNAME_RE.match(line)

if match:

« no previous file with comments | « mozharness/abb/ecosia.xml ('k') | no next file » | no next file with comments »