Issue 29556775: Issue 5518 - Add Ecosia as secondary search engine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29556775: Issue 5518 - Add Ecosia as secondary search engine (Closed)

Created:
Sept. 26, 2017, 10:56 p.m. by diegocarloslima

Modified:
Oct. 5, 2017, 3:23 p.m.

Reviewers:
anton, jens

CC:
René Jeschke, Felix Dahlke

Visibility:
Public.

Description

Issue 5518 - Add Ecosia as secondary search engine

Patch Set 1 #

Patch Set 2 : Including requested changes for ecosia search plugin xml #

Created: Oct. 3, 2017, 9:37 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	mozharness/abb/ecosia.xml	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	mozharness/abb/transform_locales.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

diegocarloslima

This change is required to avoid 'Not enough arguments for format string' error when performing ...

Sept. 26, 2017, 11:14 p.m. (2017-09-26 23:14:50 UTC) #1

anton

On 2017/09/26 23:14:50, diegocarloslima wrote: > This change is required to avoid 'Not enough arguments ...

Sept. 28, 2017, 11:26 a.m. (2017-09-28 11:26:51 UTC) #2

jens

Sept. 29, 2017, 3:20 p.m. (2017-09-29 15:20:33 UTC) #3

On 2017/09/28 11:26:51, anton wrote:
> On 2017/09/26 23:14:50, diegocarloslima wrote:
> > This change is required to avoid 'Not enough arguments for format string'
> error
> > when performing multi-locale builds
> 
> LGTM

LGTM

Expand All Messages | Collapse All Messages