lib/content/.eslintrc.json - Issue 29556808: Issue 5797 - Removed obsolete arguments from ElemHideEmulation constructor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: lib/content/.eslintrc.json

Issue 29556808: Issue 5797 - Removed obsolete arguments from ElemHideEmulation constructor (Closed)

Patch Set: Created Sept. 27, 2017, 12:18 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "env": {

	3 "browser": true
	Manish Jethani 2017/09/27 13:12:59 Is this related? Is this related? Sebastian Noack 2017/09/27 16:38:14 Since web APIs (e.g. console/setTimeout/etc.) are Show quoted text On 2017/09/27 13:12:59, Manish Jethani wrote: > Is this related? Since web APIs (e.g. console/setTimeout/etc.) are no longer accessed through the passed in window object but from the global namespace, eslint would cause lots of no-undef errors, unless we make it aware that this code is meant to run in the browser context. Note that we have a similar file in "test/browser".
	4 }

	5 }

OLD	NEW

« no previous file with comments | « no previous file | lib/content/elemHideEmulation.js » ('j') | lib/content/elemHideEmulation.js » ('J')