Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29556808: Issue 5797 - Removed obsolete arguments from ElemHideEmulation constructor (Closed)

Created:
Sept. 27, 2017, 12:18 a.m. by Sebastian Noack
Modified:
Sept. 27, 2017, 9:08 p.m.
Reviewers:
Manish Jethani, hub
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 5797 - Removed obsolete arguments from ElemHideEmulation constructor

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -69 lines) Patch
A lib/content/.eslintrc.json View 1 chunk +5 lines, -0 lines 2 comments Download
M lib/content/elemHideEmulation.js View 12 chunks +45 lines, -58 lines 1 comment Download
M test/browser/elemHideEmulation.js View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
https://codereview.adblockplus.org/29556808/diff/29556809/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29556808/diff/29556809/lib/content/elemHideEmulation.js#newcode307 lib/content/elemHideEmulation.js:307: this.document = document; We still need a way to ...
Sept. 27, 2017, 12:20 a.m. (2017-09-27 00:20:45 UTC) #1
hub
LGTM
Sept. 27, 2017, 12:39 p.m. (2017-09-27 12:39:54 UTC) #2
Manish Jethani
LGTM https://codereview.adblockplus.org/29556808/diff/29556809/lib/content/.eslintrc.json File lib/content/.eslintrc.json (right): https://codereview.adblockplus.org/29556808/diff/29556809/lib/content/.eslintrc.json#newcode3 lib/content/.eslintrc.json:3: "browser": true Is this related?
Sept. 27, 2017, 1:12 p.m. (2017-09-27 13:12:59 UTC) #3
Sebastian Noack
Sept. 27, 2017, 4:38 p.m. (2017-09-27 16:38:14 UTC) #4
https://codereview.adblockplus.org/29556808/diff/29556809/lib/content/.eslint...
File lib/content/.eslintrc.json (right):

https://codereview.adblockplus.org/29556808/diff/29556809/lib/content/.eslint...
lib/content/.eslintrc.json:3: "browser": true
On 2017/09/27 13:12:59, Manish Jethani wrote:
> Is this related?

Since web APIs (e.g. console/setTimeout/etc.) are no longer accessed through the
passed in window object but from the global namespace, eslint would cause lots
of no-undef errors, unless we make it aware that this code is meant to run in
the browser context. Note that we have a similar file in "test/browser".

Powered by Google App Engine
This is Rietveld