Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 29556820: Working Draft: CMake build for Emscripten

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by Eric
Modified:
2 weeks, 3 days ago
Reviewers:
sergei, Oleksandr, hub
CC:
Felix Dahlke
Visibility:
Public.

Description

Working Draft: CMake build for Emscripten This is a working draft of a CMake build to replace the hard-coded `compile` script currently in use.

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -0 lines) Patch
M .hgignore View 1 chunk +2 lines, -0 lines 0 comments Download
A CMakeLists.txt View 1 2 1 chunk +183 lines, -0 lines 0 comments Download
A README.CMAKE.md View 1 2 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Eric
Current maturity: OK as proof of concept, but not ready for production. The bindings file ...
7 months ago (2017-09-27 01:11:16 UTC) #1
Eric
Patch set 2 gives identical results for "bindings.js" and "compiled.js" generated by "python compile --debug". ...
6 months, 3 weeks ago (2017-10-02 18:34:34 UTC) #2
Wladimir Palant
This definitely has its rough edges... https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt File CMakeLists.txt (right): https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt#newcode19 CMakeLists.txt:19: if (${NODE_JS_EXECUTABLE} MATCHES ...
6 months, 3 weeks ago (2017-10-04 12:05:51 UTC) #3
Eric
On 2017/10/04 12:05:51, Wladimir Palant wrote: > This definitely has its rough edges... CMake always ...
6 months, 3 weeks ago (2017-10-05 13:06:01 UTC) #4
Eric
https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt File CMakeLists.txt (right): https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt#newcode19 CMakeLists.txt:19: if (${NODE_JS_EXECUTABLE} MATCHES "NOTFOUND") On 2017/10/04 12:05:50, Wladimir Palant ...
6 months, 3 weeks ago (2017-10-05 13:06:14 UTC) #5
Wladimir Palant
https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt File CMakeLists.txt (right): https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt#newcode132 CMakeLists.txt:132: target_link_libraries(compiled PRIVATE "-s SHELL_FILE=\"\\\"${SHELL_FILE}\\\"\"") It seems that you don't ...
6 months, 2 weeks ago (2017-10-09 08:49:12 UTC) #6
hub
one of the problems I noticed is that the emscripten output files are not ignored ...
6 months, 2 weeks ago (2017-10-10 14:00:59 UTC) #7
sergei
In general good so far, though I have not tried it yet. https://codereview.adblockplus.org/29556820/diff/29562630/CMakeLists.txt File CMakeLists.txt ...
6 months, 1 week ago (2017-10-17 10:58:43 UTC) #8
Eric
Patch set 3 upgrades the status of this change set from "Work in Progress" to ...
6 months, 1 week ago (2017-10-17 19:07:23 UTC) #9
hub
2 weeks, 3 days ago (2018-04-07 19:02:30 UTC) #10
We should close this now. I don't have permissions. Eric?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5