Noissue - Fix intrusive_ptr<> operator=

compiled/intrusive_ptr.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 78 matching lines @@
   {
     other.mPointer = nullptr;
   }
 
   ~intrusive_ptr()
   {
     if (mPointer)
       mPointer->ReleaseRef();
   }
 
-  intrusive_ptr& operator=(intrusive_ptr& other)
+  intrusive_ptr& operator=(const intrusive_ptr& other)

[hub, 2017/09/27 17:30:03]

it should be const & here.

   {
-    intrusive_ptr(other).swap(*this);
+    if (this != &other)

[hub, 2017/09/27 17:30:03]

we shall insure that the self assignment is a noop.

+      intrusive_ptr(other).swap(*this);
     return *this;
   }
 
   intrusive_ptr& operator=(intrusive_ptr&& other)
   {
-    intrusive_ptr(std::move(other)).swap(*this);
+    if (this != &other)

[hub, 2017/09/27 17:30:03]

same here.

+      intrusive_ptr(std::move(other)).swap(*this);
     return *this;
   }
 
   intrusive_ptr& operator=(T* other)
   {
     intrusive_ptr(other).swap(*this);
     return *this;
   }
 
   void reset()
@@ skipping 90 matching lines @@
 inline bool operator==(const T* a, const intrusive_ptr<U>& b)
 {
   return a == b.get();
 }
 
 template<typename T, typename U>
 inline bool operator!=(const T* a, intrusive_ptr<U> const& b)
 {
   return a != b.get();
 }