Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29557721: Noissue - Fix intrusive_ptr<> operator= (Closed)

Created:
Sept. 27, 2017, 5:25 p.m. by hub
Modified:
Sept. 27, 2017, 7:55 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Fix intrusive_ptr<> operator=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M compiled/intrusive_ptr.h View 1 chunk +5 lines, -3 lines 3 comments Download

Messages

Total messages: 3
hub
Sept. 27, 2017, 5:25 p.m. (2017-09-27 17:25:16 UTC) #1
hub
Reference: http://en.cppreference.com/w/cpp/language/operators This also solves the problem I have with StringMap<FilterPtr> https://codereview.adblockplus.org/29557721/diff/29557722/compiled/intrusive_ptr.h File compiled/intrusive_ptr.h (right): ...
Sept. 27, 2017, 5:30 p.m. (2017-09-27 17:30:04 UTC) #2
sergei
Sept. 27, 2017, 6:06 p.m. (2017-09-27 18:06:08 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld