Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 29557724: Issue 4699 - Edge does not support 16px and 32px icons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by Oleksandr
Modified:
1 year, 11 months ago
Reviewers:
Sebastian Noack
CC:
kzar, Manish Jethani
Visibility:
Public.

Description

Issue 4699 - Edge does not support 16px and 32px icons

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove the code duplication #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M ext/background.js View 1 1 chunk +19 lines, -11 lines 0 comments Download

Messages

Total messages: 4
Oleksandr
1 year, 11 months ago (2017-09-27 19:37:51 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29557724/diff/29557725/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29557724/diff/29557725/ext/background.js#newcode372 ext/background.js:372: } We can avoid duplication here: let path = ...
1 year, 11 months ago (2017-09-27 21:00:41 UTC) #2
Oleksandr
1 year, 11 months ago (2017-09-27 21:58:53 UTC) #3
Sebastian Noack
1 year, 11 months ago (2017-09-27 22:19:05 UTC) #4
LGTM. This can land in "master".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5