Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29558637: Issue 5806 - Acceptable ads being added to the UI on load (Closed)

Created:
Sept. 28, 2017, 4:29 p.m. by saroyanm
Modified:
Sept. 28, 2017, 5:28 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 5806 - Acceptable ads being added to the UI on load

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M new-options.js View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Thomas can you please have a look, I think it's a quick one. https://codereview.adblockplus.org/29558637/diff/29558638/new-options.html File ...
Sept. 28, 2017, 4:31 p.m. (2017-09-28 16:31:12 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29558637/diff/29558638/new-options.html File new-options.html (right): https://codereview.adblockplus.org/29558637/diff/29558638/new-options.html#newcode112 new-options.html:112: <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="none" checked> On 2017/09/28 16:31:12, ...
Sept. 28, 2017, 4:51 p.m. (2017-09-28 16:51:00 UTC) #2
saroyanm
https://codereview.adblockplus.org/29558637/diff/29558638/new-options.html File new-options.html (right): https://codereview.adblockplus.org/29558637/diff/29558638/new-options.html#newcode112 new-options.html:112: <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="none" checked> On 2017/09/28 16:50:59, ...
Sept. 28, 2017, 5:04 p.m. (2017-09-28 17:04:03 UTC) #3
saroyanm
Moved the set function after initialization of Acceptable Ads subscrpitions.
Sept. 28, 2017, 5:21 p.m. (2017-09-28 17:21:57 UTC) #4
Thomas Greiner
Sept. 28, 2017, 5:25 p.m. (2017-09-28 17:25:59 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld