new-options.html - Issue 29558637: Issue 5806 - Acceptable ads being added to the UI on load

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: new-options.html

Issue 29558637: Issue 5806 - Acceptable ads being added to the UI on load (Closed)

Patch Set: Created Sept. 28, 2017, 4:29 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: new-options.html

===================================================================

--- a/new-options.html

+++ b/new-options.html

@@ -109,7 +109,7 @@

</div>

<div>

- <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="none">

+ <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="none" checked>

saroyanm 2017/09/28 16:31:12 We want to have default selected checkbox, otherwi

Thomas Greiner 2017/09/28 16:50:59 Makes sense but let's do it programmatically by ca

saroyanm 2017/09/28 17:04:02 I agree, done.

</div>

</form>

« no previous file with comments | « no previous file | new-options.js » ('j') | no next file with comments »