Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1339)

Issue 29558641: Issue 5740 - Implemented new abp.org footer styles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by juliandoucette
Modified:
1 year, 9 months ago
Reviewers:
ire
Base URL:
https://bitbucket.org/adblockplus/adblockplus.org
Visibility:
Public.

Description

Issue 5740 - Implemented new abp.org footer styles

Patch Set 1 #

Patch Set 2 : Rebased on top of #5742 #

Total comments: 9

Patch Set 3 : Searched for and removed orphan styles #

Patch Set 4 : Rebased away learn more and grid #

Total comments: 26

Patch Set 5 : Refactored #

Total comments: 34

Patch Set 6 : Rebased on body styles #

Patch Set 7 : Rebased on header #

Total comments: 10

Patch Set 8 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -277 lines) Patch
M static/css/index-desktop.css View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M static/css/main.css View 1 2 3 4 5 6 7 2 chunks +170 lines, -66 lines 0 comments Download
M static/css/main-desktop.css View 1 2 3 4 5 6 1 chunk +0 lines, -89 lines 0 comments Download
M static/css/main-mobile.css View 1 2 3 4 5 6 1 chunk +0 lines, -50 lines 0 comments Download
M static/css/noscript-mobile.css View 1 chunk +0 lines, -10 lines 0 comments Download
A static/img/footer-facebook-glyphicon.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
A static/img/footer-instagram-glyphicon.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
A static/img/footer-twitter-glyphicon.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
A static/img/footer-youtube-glyphicon.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
M static/js/main.js View 1 2 3 4 5 6 1 chunk +0 lines, -23 lines 0 comments Download
M templates/default.tmpl View 1 2 3 4 5 6 7 1 chunk +56 lines, -38 lines 0 comments Download

Messages

Total messages: 17
juliandoucette
1 year, 9 months ago (2017-09-28 16:33:02 UTC) #1
juliandoucette
First draft. This is pretty messy. I'll review myself too.
1 year, 9 months ago (2017-09-28 16:33:22 UTC) #2
juliandoucette
More updates coming. Sorry for the delay. https://codereview.adblockplus.org/29558641/diff/29565736/includes/index.tmpl File includes/index.tmpl (left): https://codereview.adblockplus.org/29558641/diff/29565736/includes/index.tmpl#oldcode188 includes/index.tmpl:188: <section class="hidden" ...
1 year, 9 months ago (2017-10-05 16:04:21 UTC) #3
juliandoucette
Added some notes. https://codereview.adblockplus.org/29558641/diff/29565736/static/css/index-desktop.css File static/css/index-desktop.css (left): https://codereview.adblockplus.org/29558641/diff/29565736/static/css/index-desktop.css#oldcode4 static/css/index-desktop.css:4: margin-bottom: 290px; Because #footer-main was absolutely ...
1 year, 9 months ago (2017-10-05 17:09:57 UTC) #4
juliandoucette
Properly rebased. I'm updating this implementation now.
1 year, 9 months ago (2017-10-06 11:48:01 UTC) #5
juliandoucette
Ready for review. Note: I changed font-sizes from px to em according to the sizes ...
1 year, 9 months ago (2017-10-06 12:58:01 UTC) #6
juliandoucette
Added afterthoughts / things I noticed at a glance. https://codereview.adblockplus.org/29558641/diff/29567730/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29558641/diff/29567730/static/css/main.css#newcode254 static/css/main.css:254: ...
1 year, 9 months ago (2017-10-06 13:03:41 UTC) #7
ire
On 2017/10/06 12:58:01, juliandoucette wrote: > Ready for review. > > Note: I changed font-sizes ...
1 year, 9 months ago (2017-10-09 10:37:21 UTC) #8
ire
Thanks Julian! Comments below. https://codereview.adblockplus.org/29558641/diff/29567717/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29558641/diff/29567717/static/css/main.css#newcode330 static/css/main.css:330: #site-footer h5 On 2017/10/06 12:57:58, ...
1 year, 9 months ago (2017-10-09 10:38:05 UTC) #9
juliandoucette
Quick response. https://codereview.adblockplus.org/29558641/diff/29567730/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29558641/diff/29567730/static/css/main.css#newcode303 static/css/main.css:303: /******************************************************************************* On 2017/10/09 10:38:03, ire wrote: > ...
1 year, 9 months ago (2017-10-09 16:44:13 UTC) #10
ire
https://codereview.adblockplus.org/29558641/diff/29567730/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29558641/diff/29567730/static/css/main.css#newcode303 static/css/main.css:303: /******************************************************************************* On 2017/10/09 16:44:12, juliandoucette wrote: > On 2017/10/09 ...
1 year, 9 months ago (2017-10-09 17:01:14 UTC) #11
juliandoucette
Rebased
1 year, 9 months ago (2017-10-11 12:11:00 UTC) #12
juliandoucette
Ready for review
1 year, 9 months ago (2017-10-11 13:11:32 UTC) #13
juliandoucette
Added notes, Ready for review. https://codereview.adblockplus.org/29558641/diff/29567717/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29558641/diff/29567717/static/css/main.css#newcode409 static/css/main.css:409: margin-right: 10px; On 2017/10/09 ...
1 year, 9 months ago (2017-10-11 13:12:10 UTC) #14
ire
Thanks! LGTM https://codereview.adblockplus.org/29558641/diff/29567730/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29558641/diff/29567730/templates/default.tmpl#newcode185 templates/default.tmpl:185: <a rel="nofollow" href="https://twitter.com/AdblockPlus" target="_blank"> On 2017/10/11 13:12:08, ...
1 year, 9 months ago (2017-10-11 16:28:33 UTC) #15
juliandoucette
On 2017/10/11 16:28:33, ire wrote: > Since there are no longer any styles for #footer-main, ...
1 year, 9 months ago (2017-10-11 17:55:54 UTC) #16
juliandoucette
1 year, 9 months ago (2017-10-12 11:51:20 UTC) #17

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5