Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29558654: Noissue - Capitalize section titles, incresed line-height of tooltips and removed wrap from custom … (Closed)

Created:
Sept. 28, 2017, 4:50 p.m. by saroyanm
Modified:
Sept. 29, 2017, 11:37 a.m.
Reviewers:
ire
Visibility:
Public.

Description

Noissue - Capitalize section titles, incresed line-height of tooltips and removed wrap from custom …

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use help cursor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M locale/en-US/new-options.json View 1 chunk +1 line, -1 line 0 comments Download
M new-options.html View 1 chunk +1 line, -1 line 0 comments Download
M skin/new-options.css View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3
saroyanm
@Ire can you please have a look, this are small changes I thought they have ...
Sept. 28, 2017, 4:52 p.m. (2017-09-28 16:52:51 UTC) #1
ire
Thanks Manvel. This LGTM. One suggestion below. https://codereview.adblockplus.org/29558654/diff/29558659/skin/new-options.css File skin/new-options.css (right): https://codereview.adblockplus.org/29558654/diff/29558659/skin/new-options.css#newcode894 skin/new-options.css:894: cursor: default; ...
Sept. 29, 2017, 8:09 a.m. (2017-09-29 08:09:37 UTC) #2
saroyanm
Sept. 29, 2017, 11:35 a.m. (2017-09-29 11:35:53 UTC) #3
Thanks Ire :)

https://codereview.adblockplus.org/29558654/diff/29558659/skin/new-options.css
File skin/new-options.css (right):

https://codereview.adblockplus.org/29558654/diff/29558659/skin/new-options.cs...
skin/new-options.css:894: cursor: default;
On 2017/09/29 08:09:36, ire wrote:
> Suggestion: I think the `help` cursor would be appropriate here

Agree, done.

Powered by Google App Engine
This is Rietveld