 Issue 29559620:
  Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29559620:
  Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Index: static/scss/components/_select.scss | 
| =================================================================== | 
| --- a/static/scss/components/_select.scss | 
| +++ b/static/scss/components/_select.scss | 
| @@ -47,16 +47,17 @@ | 
| margin-bottom: 0.5em; | 
| padding: 0.7em; | 
| border: 1px solid $gray-medium; | 
| border-radius: 4px; | 
| box-shadow: 0px 0px 10px 0px rgba(0, 0, 0, 0.3); | 
| color: $black; | 
| background: $white; | 
| list-style: none; | 
| + z-index: 2; | 
| a | 
| { | 
| color: $black; | 
| } | 
| } | 
| .custom-select-options[aria-hidden="true"] | 
| @@ -97,8 +98,71 @@ | 
| content: none; | 
| } | 
| a | 
| { | 
| color: inherit; | 
| } | 
| } | 
| + | 
| +// Custom Dropdown (extends the custom select element) | 
| + | 
| +.custom-select-dropdown img | 
| 
juliandoucette
2017/10/13 13:39:57
NIT: I think this image is supposed to be larger?
 
ire
2017/10/17 15:03:35
I think you're right. I would like to change this:
 
juliandoucette
2017/10/18 15:04:11
Acknowledged.
 | 
| +{ | 
| + @extend .heading-icon; | 
| +} | 
| + | 
| +.custom-select-dropdown .custom-select-selected, | 
| +.custom-select-dropdown .custom-select-options | 
| +{ | 
| + width: 100%; | 
| +} | 
| + | 
| +.custom-select-dropdown .custom-select-selected | 
| +{ | 
| + position: relative; | 
| + height: 40px; | 
| 
juliandoucette
2017/10/13 13:39:57
NIT: It's inconsistent to mix px and em here
 
ire
2017/10/17 15:03:35
Done.
 | 
| + padding-right: 2.5em; | 
| + color: $primary; | 
| + text-align: left; | 
| +} | 
| + | 
| +[dir="rtl"] .custom-select-dropdown .custom-select-selected | 
| +{ | 
| + padding-right: 0.7em; | 
| + padding-left: 2.5em; | 
| + text-align: right; | 
| +} | 
| + | 
| +.custom-select-dropdown .custom-select-selected:after | 
| +{ | 
| + position: absolute; | 
| + top: 0; | 
| + right: 0; | 
| + width: 2em; | 
| 
juliandoucette
2017/10/13 13:39:57
NIT: This looks wider in the mockups? 3em? (one wi
 
ire
2017/10/17 15:03:35
Done.
 | 
| + height: 100%; | 
| + border-left: 2px solid $gray-medium; | 
| 
juliandoucette
2017/10/13 13:39:57
NIT: This looks like 1px in the mockups? (The same
 
ire
2017/10/17 15:03:35
We changed it to 2px because you said it was too t
 | 
| + background-image: url(/img/png/arrow-down-icon-secondary.png); | 
| 
juliandoucette
2017/10/13 13:39:56
NIT: Can we use SVG or 2x PNG and fallback to 1x p
 
ire
2017/10/17 15:03:35
I know it's possible to set multiple background-im
 
juliandoucette
2017/10/18 15:04:11
https://css-tricks.com/svg-fallbacks/#article-head
 
ire
2017/10/20 13:40:48
Neat! Done.
 | 
| + background-repeat: no-repeat; | 
| + background-position: center; | 
| + background-size: 0.7em; | 
| + content: ""; | 
| +} | 
| + | 
| +[dir="rtl"] .custom-select-dropdown .custom-select-selected:after | 
| +{ | 
| + right: auto; | 
| + left: 0; | 
| + border-right: 2px solid $gray-medium; | 
| + border-left: 0; | 
| +} | 
| + | 
| +.custom-select-dropdown .custom-select-options | 
| +{ | 
| + top: 100%; | 
| + bottom: auto; | 
| +} | 
| + | 
| +.custom-select-dropdown .custom-select-options li | 
| +{ | 
| + line-height: 40px; | 
| 
juliandoucette
2017/10/13 13:39:56
NIT: It's inconsistent to mix px and em here
 
ire
2017/10/17 15:03:35
Done.
 | 
| +} |