Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29563558: Issue 5823 - Change header content based on page on help.eyeo.com (Closed)

Created:
Oct. 3, 2017, 8:06 a.m. by ire
Modified:
Oct. 11, 2017, 5:05 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5823 - Change header content based on page on help.eyeo.com

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase and place help center url first in search sites #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M includes/layout/header.tmpl View 1 1 chunk +17 lines, -6 lines 0 comments Download
M settings.ini View 1 chunk +1 line, -0 lines 2 comments Download
M static/scss/layout/_header.scss View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6
ire
Oct. 3, 2017, 8:06 a.m. (2017-10-03 08:06:55 UTC) #1
ire
Ready for review (forgot to say)
Oct. 5, 2017, 2:35 p.m. (2017-10-05 14:35:33 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29563558/diff/29563559/includes/layout/header.tmpl File includes/layout/header.tmpl (right): https://codereview.adblockplus.org/29563558/diff/29563559/includes/layout/header.tmpl#newcode4 includes/layout/header.tmpl:4: {% set search_site = product.url + "," + config.get("general", ...
Oct. 9, 2017, 10:58 p.m. (2017-10-09 22:58:06 UTC) #3
ire
https://codereview.adblockplus.org/29563558/diff/29563559/includes/layout/header.tmpl File includes/layout/header.tmpl (right): https://codereview.adblockplus.org/29563558/diff/29563559/includes/layout/header.tmpl#newcode4 includes/layout/header.tmpl:4: {% set search_site = product.url + "," + config.get("general", ...
Oct. 10, 2017, 6:44 p.m. (2017-10-10 18:44:48 UTC) #4
juliandoucette
LGTM + NIT https://codereview.adblockplus.org/29563558/diff/29572888/settings.ini File settings.ini (right): https://codereview.adblockplus.org/29563558/diff/29572888/settings.ini#newcode2 settings.ini:2: siteurl=https://help.eyeo.com NIT: Missing spaces
Oct. 11, 2017, 3:11 p.m. (2017-10-11 15:11:28 UTC) #5
ire
Oct. 11, 2017, 5:05 p.m. (2017-10-11 17:05:36 UTC) #6 
https://codereview.adblockplus.org/29563558/diff/29572888/settings.ini
File settings.ini (right):

https://codereview.adblockplus.org/29563558/diff/29572888/settings.ini#newcode2
settings.ini:2: siteurl=https://help.eyeo.com
On 2017/10/11 15:11:28, juliandoucette wrote:
> NIT: Missing spaces

Done.

Powered by Google App Engine
This is Rietveld