Issue 5636 - Refactored language selector to use og locale location codes instead of locale codes

Issue 5636 - Refactored language selector to use og locale location codes instead of locale codes

[ire, 2017-10-04 22:09:36]

A couple of NITs, but otherwise LGTM

https://codereview.adblockplus.org/29564702/diff/29564703/filters/to_og_locat...
File filters/to_og_location.py (right):

https://codereview.adblockplus.org/29564702/diff/29564703/filters/to_og_locat...
filters/to_og_location.py:1: def to_og_location(og_locale):
NIT: Missing copyright notice

https://codereview.adblockplus.org/29564702/diff/29564703/templates/default.tmpl
File templates/default.tmpl (right):

https://codereview.adblockplus.org/29564702/diff/29564703/templates/default.t...
templates/default.tmpl:101: {{ config.get("langnames", locale) }} ({{ locale |
to_og_locale | to_og_location }})
NIT: I'm not 100% sure about building the `to_og_location` on top of
`to_og_locale`. I think it may be cleaner to either modify the `to_og_locale` or
create a standalone `to_og_location` that takes in the `locale` (The
`og_locales` will have to be moved to their own file to be used by both
filters). I don't feel particularly strongly about this, so feel free to ignore
if you prefer this method.

[juliandoucette, 2017-10-05 12:11:12]

Thanks!

https://codereview.adblockplus.org/29564702/diff/29564703/filters/to_og_locat...
File filters/to_og_location.py (right):

https://codereview.adblockplus.org/29564702/diff/29564703/filters/to_og_locat...
filters/to_og_location.py:1: def to_og_location(og_locale):
On 2017/10/04 22:09:35, ire wrote:
> NIT: Missing copyright notice

Acknowledged.

https://codereview.adblockplus.org/29564702/diff/29564703/templates/default.tmpl
File templates/default.tmpl (right):

https://codereview.adblockplus.org/29564702/diff/29564703/templates/default.t...
templates/default.tmpl:101: {{ config.get("langnames", locale) }} ({{ locale |
to_og_locale | to_og_location }})
On 2017/10/04 22:09:35, ire wrote:
> NIT: I'm not 100% sure about building the `to_og_location` on top of
> `to_og_locale`. I think it may be cleaner to either modify the `to_og_locale`
or
> create a standalone `to_og_location` that takes in the `locale` (The
> `og_locales` will have to be moved to their own file to be used by both
> filters). I don't feel particularly strongly about this, so feel free to
ignore
> if you prefer this method.

Funny you should say... https://issues.adblockplus.org/ticket/5830#comment:1

[juliandoucette, 2017-10-05 12:17:39]

https://codereview.adblockplus.org/29564702/diff/29564703/filters/to_og_locat...
File filters/to_og_location.py (right):

https://codereview.adblockplus.org/29564702/diff/29564703/filters/to_og_locat...
filters/to_og_location.py:1: def to_og_location(og_locale):
On 2017/10/04 22:09:35, ire wrote:
> NIT: Missing copyright notice

Done.

[juliandoucette, 2017-10-05 15:22:50]

https://bitbucket.org/adblockplus/adblockplus.org/commits/fab868ea24848c49524...