Issue 5235 - Refactoring on SharedPrefs

Issue 5235 - Refactoring on SharedPrefs

[anton, 2017-10-05 12:49:50]

https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
File adblockplussbrowser/res/values/sysarrays.xml (right):

https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
adblockplussbrowser/res/values/sysarrays.xml:6:
<item>@string/download_settings_value_always</item>
why there is no renaming 'download_settings_always' to
'download_settings_value_always'? other string resource xml?

[diegocarloslima, 2017-10-05 12:55:46]

LGTM

https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
File adblockplussbrowser/res/values/sysarrays.xml (right):

https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
adblockplussbrowser/res/values/sysarrays.xml:6:
<item>@string/download_settings_value_always</item>
On 2017/10/05 12:49:50, anton wrote:
> why there is no renaming 'download_settings_always' to
> 'download_settings_value_always'? other string resource xml?

This should have been `download_settings_value_always` since the beginning... It
was a mistake that I made by using `download_settings_always` here

[anton, 2017-10-05 12:57:36]

On 2017/10/05 12:55:46, diegocarloslima wrote:
> LGTM
> 
>
https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
> File adblockplussbrowser/res/values/sysarrays.xml (right):
> 
>
https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
> adblockplussbrowser/res/values/sysarrays.xml:6:
> <item>@string/download_settings_value_always</item>
> On 2017/10/05 12:49:50, anton wrote:
> > why there is no renaming 'download_settings_always' to
> > 'download_settings_value_always'? other string resource xml?
> 
> This should have been `download_settings_value_always` since the beginning...
It
> was a mistake that I made by using `download_settings_always` here

ok, i did not catch it because of "refactoring" in the title so i expect
everything was working before.
then LGTM

[jens, 2017-10-05 12:59:38]

On 2017/10/05 12:57:36, anton wrote:
> On 2017/10/05 12:55:46, diegocarloslima wrote:
> > LGTM
> > 
> >
>
https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
> > File adblockplussbrowser/res/values/sysarrays.xml (right):
> > 
> >
>
https://codereview.adblockplus.org/29565696/diff/29565697/adblockplussbrowser...
> > adblockplussbrowser/res/values/sysarrays.xml:6:
> > <item>@string/download_settings_value_always</item>
> > On 2017/10/05 12:49:50, anton wrote:
> > > why there is no renaming 'download_settings_always' to
> > > 'download_settings_value_always'? other string resource xml?
> > 
> > This should have been `download_settings_value_always` since the
beginning...
> It
> > was a mistake that I made by using `download_settings_always` here
> 
> ok, i did not catch it because of "refactoring" in the title so i expect
> everything was working before.
> then LGTM

I was just about to type a comment to explain this. Thanks for clarifying,
diego.