Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29565802: Issue 5836 - Update buildtools dependency in adblockplusui (Closed)

Created:
Oct. 5, 2017, 7:43 p.m. by Sebastian Noack
Modified:
Oct. 11, 2017, 6:38 p.m.
Reviewers:
tlucas, Thomas Greiner
Visibility:
Public.

Description

Issue 5836 - Update buildtools dependency in adblockplusui

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased and updated dependency #

Patch Set 3 : Fixed default_locale #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -89 lines) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 1 13 chunks +149 lines, -105 lines 0 comments Download
M locale/bn/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/en_GB/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/en_US/antiadblockInit.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/en_US/common.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/en_US/desktop-options.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/en_US/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/en_US/mobile-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/es/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/es_AR/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/es_CL/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/es_MX/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/fy/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/hi/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/hy/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/nb/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/pt_BR/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/pt_PT/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/sv/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/ta/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/zh_CN/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locale/zh_TW/firstRun.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M metadata.generic View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
https://codereview.adblockplus.org/29565802/diff/29565803/dependencies File dependencies (right): https://codereview.adblockplus.org/29565802/diff/29565803/dependencies#newcode3 dependencies:3: buildtools = buildtools hg:???????????? git:??????? This still needs to ...
Oct. 5, 2017, 7:45 p.m. (2017-10-05 19:45:46 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29565802/diff/29565803/metadata.generic File metadata.generic (left): https://codereview.adblockplus.org/29565802/diff/29565803/metadata.generic#oldcode8 metadata.generic:8: target_platforms = chrome firefox The ticket mentions that "name_format", ...
Oct. 6, 2017, 12:34 p.m. (2017-10-06 12:34:05 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29565802/diff/29565803/metadata.generic File metadata.generic (left): https://codereview.adblockplus.org/29565802/diff/29565803/metadata.generic#oldcode8 metadata.generic:8: target_platforms = chrome firefox On 2017/10/06 12:34:05, Thomas Greiner ...
Oct. 6, 2017, 5:25 p.m. (2017-10-06 17:25:19 UTC) #3
Thomas Greiner
LGTM as soon as the dependencies file will be updated
Oct. 6, 2017, 6:03 p.m. (2017-10-06 18:03:39 UTC) #4
Sebastian Noack
The relevant changes landed in buildtools. I updated the dependencies file and rebased.
Oct. 10, 2017, 6:52 p.m. (2017-10-10 18:52:42 UTC) #5
Thomas Greiner
LGTM
Oct. 11, 2017, 10:35 a.m. (2017-10-11 10:35:52 UTC) #6
tlucas
Oct. 11, 2017, 10:40 a.m. (2017-10-11 10:40:36 UTC) #7 
Applies cleanly and builds seem to succeed.
LGTM

Powered by Google App Engine
This is Rietveld