Noissue - Fix flake8-eyeo for flake8 3.4

Noissue - Fix flake8-eyeo for flake8 3.4

[Sebastian Noack, 2017-10-06 02:09:55]

Starting with flake 8 3.4.0, all errors detected by flake8-eyeo are ignored,
except when specifying --select=A. Also see
https://gitlab.com/pycqa/flake8/issues/318#note_42573002.

[Vasily Kuznetsov, 2017-10-06 11:00:11]

LGTM.

Do you know if they are planning to fix this "feature" or if this change brings
us to the "correct" way of registering plugins now? According to the
documentation it seems like the latter
(http://flake8.pycqa.org/en/latest/plugin-development/registering-plugins.html)
but I'm wondering if you found something else while looking into it.

[tlucas, 2017-10-06 11:45:41]

LGTM - Nice to know, that we could use flake8 v3 now :)

[Sebastian Noack, 2017-10-06 18:50:00]

On 2017/10/06 11:00:11, Vasily Kuznetsov wrote:
> Do you know if they are planning to fix this "feature" or if this change
brings
> us to the "correct" way of registering plugins now?

To me it seems to be an unintentional regression. Note that the previous way we
registered the plugin still works, but merely causes our errors to be ignored by
default, and the change causing this doesn't mention anything about plugins, and
it doesn't touch any plugin support code directly. But I still hope to get a
reply to my comment on GitLab.

But FWIW, this way we can at least support flake8 2+3 with the same mechanism.
However, note that this didn't work before with flake8 3.0.0, which was the
reason we changed the way the plugin is registered in the first place. So far
for a stable API. If there is anything we can trust in, is that they keep
breaking plugins. ;)

On 2017/10/06 11:45:41, tlucas wrote:
> LGTM - Nice to know, that we could use flake8 v3 now :)

Well, we already use flake8 3, except for buildtools, sitescripts and cms. The
reason we cannot use flake8 3 there yet, is the flake8-putty plugin which is
incompatible with flake8 3. However, flake8-eyeo has been compatible since
flake8 3 has been released, but they keep breaking the API.