Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/subscriptionInit.js

Issue 29567798: Noissue - Replace ext.pages.open with tabs.create (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Remove ext.pages.open implementation Created Oct. 8, 2017, 9:45 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/notificationHelper.js ('k') | notification.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/subscriptionInit.js
===================================================================
--- a/lib/subscriptionInit.js
+++ b/lib/subscriptionInit.js
@@ -200,17 +200,17 @@
{
FilterStorage.addSubscription(subscription);
if (subscription instanceof DownloadableSubscription &&
!subscription.lastDownload)
Synchronizer.execute(subscription);
}
if (firstRun && !Prefs.suppress_first_run_page)
- ext.pages.open(ext.getURL("firstRun.html"));
+ chrome.tabs.create({url: ext.getURL("firstRun.html")});
initNotifications();
}
Promise.all([FilterNotifier.once("load"),
Prefs.untilLoaded]).then(detectFirstRun)
.then(getSubscriptions)
.then(finishInitialization);
« no previous file with comments | « lib/notificationHelper.js ('k') | notification.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld