Unified Diff: notification.js
Issue 29567798:
Noissue - Replace ext.pages.open with tabs.create (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Remove ext.pages.open implementation
Created Oct. 8, 2017, 9:45 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/subscriptionInit.js ('k')
|
stats.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: notification.js |
| =================================================================== |
| --- a/notification.js |
| +++ b/notification.js |
| @@ -79,17 +79,17 @@ |
| { |
| let link = event.target; |
| while (link && link !== messageElement && link.localName !== "a") |
| link = link.parentNode; |
| if (!link) |
| return; |
| event.preventDefault(); |
| event.stopPropagation(); |
| - ext.pages.open(link.href); |
| + chrome.tabs.create({url: link.href}); |
| }); |
| let notificationElement = document.getElementById("notification"); |
| notificationElement.className = notification.type; |
| notificationElement.hidden = false; |
| notificationElement.addEventListener("click", event => |
| { |
| if (event.target.id == "notification-close") |
« no previous file with comments
|
« lib/subscriptionInit.js ('k')
|
stats.js » ('j')
|
no next file with comments »
