Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29569561: Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (buildtools) (Closed)

Created:
Oct. 8, 2017, 5:50 p.m. by Sebastian Noack
Modified:
Oct. 10, 2017, 4:59 a.m.
Visibility:
Public.

Description

Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (buildtools)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M build.py View 1 chunk +1 line, -0 lines 0 comments Download
M ensure_dependencies.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tox.ini View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
The whitespace changes were due to the flake8 update, as flake8 2 didn't log an ...
Oct. 8, 2017, 6:15 p.m. (2017-10-08 18:15:36 UTC) #1
Vasily Kuznetsov
On 2017/10/08 18:15:36, Sebastian Noack wrote: > The whitespace changes were due to the flake8 ...
Oct. 9, 2017, 8:31 p.m. (2017-10-09 20:31:13 UTC) #2
tlucas
LGTM, i'm really looking forward to this! :)
Oct. 9, 2017, 11:19 p.m. (2017-10-09 23:19:12 UTC) #3
Sebastian Noack
Oct. 10, 2017, 4:29 a.m. (2017-10-10 04:29:11 UTC) #4
On 2017/10/09 20:31:13, Vasily Kuznetsov 
> LGTM. I assume the removed ignores were triggering X100 and that's why you've
> removed them.

Exactly. :)

Powered by Google App Engine
This is Rietveld