Unified Diff: lib/icon.js
Issue 29569615:
Noissue - Replace ext.pages.query with tabs.query (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set:
Created Oct. 8, 2017, 11:37 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/filterComposer.js ('k')
|
lib/options.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/icon.js |
| =================================================================== |
| --- a/lib/icon.js |
| +++ b/lib/icon.js |
| @@ -139,18 +139,20 @@ |
| } |
| return frames; |
| }); |
| } |
| function animateIcon(notificationType, frames) |
| { |
| - ext.pages.query({active: true}, pages => |
| + chrome.tabs.query({active: true}, tabs => |
| { |
| + let pages = tabs.map(tab => new ext.Page(tab)); |
| + |
| let animationStep = 0; |
| let opacity = 0; |
| let onActivated = page => |
| { |
| pages.push(page); |
| setIcon(page, notificationType, opacity, frames); |
| }; |
« no previous file with comments
|
« lib/filterComposer.js ('k')
|
lib/options.js » ('j')
|
no next file with comments »
