Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterComposer.js

Issue 29569615: Noissue - Replace ext.pages.query with tabs.query (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Oct. 8, 2017, 11:37 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/background.js ('k') | lib/icon.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterComposer.js
===================================================================
--- a/lib/filterComposer.js
+++ b/lib/filterComposer.js
@@ -190,20 +190,20 @@
page.contextMenus.create(contextMenuItem);
}
}
FilterNotifier.on("page.WhitelistingStateRevalidate", updateContextMenu);
Prefs.on("shouldShowBlockElementMenu", () =>
{
- ext.pages.query({}, pages =>
+ chrome.tabs.query({}, tabs =>
{
- for (let page of pages)
- updateContextMenu(page);
+ for (let tab of tabs)
+ updateContextMenu(new ext.Page(tab));
});
});
port.on("composer.isPageReady", (message, sender) =>
{
return readyPages.has(new ext.Page({id: message.pageId}));
});
« no previous file with comments | « ext/background.js ('k') | lib/icon.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld