Noissue - Adjustments related to copyright text

Noissue - Adjustments related to copyright text

[anton, 2017-10-10 06:20:58]

https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base...
File mobile/android/base/resources/drawable/abb_start_pane_button.xml (right):

https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base...
mobile/android/base/resources/drawable/abb_start_pane_button.xml:3: - This file
is part of the Adblock Plus <https://adblockplus.org/>,
We do we have "-" at the beginning of every line?

[jens, 2017-10-10 14:10:39]

https://codereview.adblockplus.org/29570589/diff/29570590/translations.py
File translations.py (right):

https://codereview.adblockplus.org/29570589/diff/29570590/translations.py#new...
translations.py:16: # along with Adblock Plus.  If not, see
<http://www.gnu.org/licenses/>.
Very minor, but why are we using two whitespaces here and before the word 'See'
in the paragraph above?

[diegocarloslima, 2017-10-10 14:29:39]

https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base...
File mobile/android/base/resources/drawable/abb_start_pane_button.xml (right):

https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base...
mobile/android/base/resources/drawable/abb_start_pane_button.xml:3: - This file
is part of the Adblock Plus <https://adblockplus.org/>,
On 2017/10/10 06:20:58, anton wrote:
> We do we have "-" at the beginning of every line?

Yeah, the '-' is already used in other .xml files which have the copyright text
such as
https://hg.adblockplus.org/adblockbrowser/file/7018960f20ac/mobile/android/ba...

https://codereview.adblockplus.org/29570589/diff/29570590/translations.py
File translations.py (right):

https://codereview.adblockplus.org/29570589/diff/29570590/translations.py#new...
translations.py:16: # along with Adblock Plus.  If not, see
<http://www.gnu.org/licenses/>.
On 2017/10/10 14:10:39, jens wrote:
> Very minor, but why are we using two whitespaces here and before the word
'See'
> in the paragraph above?

Good point. Actually I don't know the reasoning behind that. I just copied the
default copyright text for Python files, that can be found, for example, here
https://hg.adblockplus.org/codingtools/file/tip/patchconv/patchconv.py and here
https://hg.adblockplus.org/python-abp/file/tip/abp/filters/parser.py

[jens, 2017-10-11 08:01:22]

On 2017/10/10 14:29:39, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base...
> File mobile/android/base/resources/drawable/abb_start_pane_button.xml (right):
> 
>
https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base...
> mobile/android/base/resources/drawable/abb_start_pane_button.xml:3: - This
file
> is part of the Adblock Plus <https://adblockplus.org/>,
> On 2017/10/10 06:20:58, anton wrote:
> > We do we have "-" at the beginning of every line?
> 
> Yeah, the '-' is already used in other .xml files which have the copyright
text
> such as
>
https://hg.adblockplus.org/adblockbrowser/file/7018960f20ac/mobile/android/ba...
> 
> https://codereview.adblockplus.org/29570589/diff/29570590/translations.py
> File translations.py (right):
> 
>
https://codereview.adblockplus.org/29570589/diff/29570590/translations.py#new...
> translations.py:16: # along with Adblock Plus.  If not, see
> <http://www.gnu.org/licenses/>.
> On 2017/10/10 14:10:39, jens wrote:
> > Very minor, but why are we using two whitespaces here and before the word
> 'See'
> > in the paragraph above?
> 
> Good point. Actually I don't know the reasoning behind that. I just copied the
> default copyright text for Python files, that can be found, for example, here
> https://hg.adblockplus.org/codingtools/file/tip/patchconv/patchconv.py and
here
> https://hg.adblockplus.org/python-abp/file/tip/abp/filters/parser.py

Yeah, I also found this spacing in ABP for Samsung Internet. Do you think we
should start correcting it?

[anton, 2017-10-12 05:47:40]

On 2017/10/10 14:10:39, jens wrote:
> https://codereview.adblockplus.org/29570589/diff/29570590/translations.py
> File translations.py (right):
> 
>
https://codereview.adblockplus.org/29570589/diff/29570590/translations.py#new...
> translations.py:16: # along with Adblock Plus.  If not, see
> <http://www.gnu.org/licenses/>.
> Very minor, but why are we using two whitespaces here and before the word
'See'
> in the paragraph above?

Vasily has answered about the reason:
https://codereview.adblockplus.org/29567648/#msg7

[anton, 2017-10-12 05:48:37]

On 2017/10/09 14:55:14, diegocarloslima wrote:

LGTM

[jens, 2017-10-12 07:54:14]

On 2017/10/12 05:48:37, anton wrote:
> On 2017/10/09 14:55:14, diegocarloslima wrote:
> 
> LGTM

LGTM