Issue 5593 - Merge notification.js and stats.js into popup.js

Issue 5593 - Merge notification.js and stats.js into popup.js

Depends on https://codereview.adblockplus.org/29569649/

[Manish Jethani, 2017-10-09 17:43:24]

Patch Set 1

https://codereview.adblockplus.org/29570774/diff/29570775/ext/popup.js
File ext/popup.js (left):

https://codereview.adblockplus.org/29570774/diff/29570775/ext/popup.js#oldcode7
ext/popup.js:7: const backgroundPage = chrome.extension.getBackgroundPage();
Finally there's no need to access the background page. This should fix issue
#5593.

https://codereview.adblockplus.org/29570774/diff/29570775/popup.html
File popup.html (left):

https://codereview.adblockplus.org/29570774/diff/29570775/popup.html#oldcode24
popup.html:24: <script src="ext/common.js"></script>
The code in ext/common.js will eventually make it into polyfill.js as part of
https://codereview.adblockplus.org/29570614/

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js
File popup.js (right):

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js#newcode193
popup.js:193: (function()
The logic inside these anonymous functions needs to be brought out and merged
with the rest of the code.

[Sebastian Noack, 2017-10-09 19:29:47]

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js
File popup.js (right):

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js#newcode193
popup.js:193: (function()
On 2017/10/09 17:43:24, Manish Jethani wrote:
> The logic inside these anonymous functions needs to be brought out and merged
> with the rest of the code.

Yeah, please, go ahead.

[Manish Jethani, 2017-10-10 05:08:57]

Patch Set 2: Merge code

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js
File popup.js (right):

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js#newcode73
popup.js:73: function onLoad()
onLoad has been inlined, i.e. it's an anonymous function passed directly to
addEventListener.

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js#newcode193
popup.js:193: (function()
On 2017/10/09 19:29:46, Sebastian Noack wrote:
> On 2017/10/09 17:43:24, Manish Jethani wrote:
> > The logic inside these anonymous functions needs to be brought out and
merged
> > with the rest of the code.
> 
> Yeah, please, go ahead.

Done.

https://codereview.adblockplus.org/29570774/diff/29570775/popup.js#newcode372
popup.js:372: tab: currentTab
Note: There's no currentTab anymore, it's just tab

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js
File popup.js (right):

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js#newcode20
popup.js:20: const shareURL = "https://adblockplus.org/";
These from stats.js are now constants here.

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js#newcode139
popup.js:139: function getDocLinks(notification)
This is from notification.js

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js#newcode184
popup.js:184: function createShareLink(network, blockedCount)
This is from stats.js

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js#newcode299
popup.js:299: updateStats();
These two lines from the previously separate onLoad from stats.js

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js#newcode333
popup.js:333: document.getElementById("share-box").addEventListener("click",
share,
onLoad code from stats.js

https://codereview.adblockplus.org/29570774/diff/29571621/popup.js#newcode346
popup.js:346: window.addEventListener("load", () =>
Nothing has changed in the window's "load" handler.

[Manish Jethani, 2017-10-10 05:16:11]

Patch Set 3: Remove optional useCapture argument

This was there probably for legacy reasons, it's no longer needed [1]

[1]:
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

[Manish Jethani, 2017-10-10 05:17:31]

Patch Set 4: Rename ev to event

[Manish Jethani, 2017-10-10 05:19:51]

Note that this patch is based on https://codereview.adblockplus.org/29569649/

[Sebastian Noack, 2017-10-10 05:38:19]

Thanks for the improvements (and for doing them in a separate patch set), LGTM!