Noissue - Use sets in build.py were appropriate

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
 from getopt import getopt, GetoptError
 from StringIO import StringIO
 from zipfile import ZipFile
 
-knownTypes = ('gecko-webext', 'chrome', 'generic', 'edge')
+knownTypes = {'gecko-webext', 'chrome', 'generic', 'edge'}
 
 
 class Command(object):
     name = property(lambda self: self._name)
     shortDescription = property(
         lambda self: self._shortDescription,
         lambda self, value: self.__dict__.update({'_shortDescription': value})
     )
     description = property(
         lambda self: self._description,
@@ skipping 357 matching lines @@
 with addCommand(lambda baseDir, scriptName, opts, args, type: usage(scriptName, type), ('help', '-h', '--help')) as command:
     command.shortDescription = 'Show this message'
 
 with addCommand(runBuild, 'build') as command:
     command.shortDescription = 'Create a build'
     command.description = 'Creates an extension build with given file name. If output_file is missing a default name will be chosen.'
     command.params = '[options] [output_file]'
     command.addOption('Use given build number (if omitted the build number will be retrieved from Mercurial)', short='b', long='build', value='num')
     command.addOption('File containing private key and certificates required to sign the package', short='k', long='key', value='file', types=('chrome',))
     command.addOption('Create a release build', short='r', long='release')
     command.supportedTypes = ('gecko-webext', 'chrome', 'edge')

[Sebastian Noack, 2017/10/10 18:34:28]

Can we please turn these into sets as well?

[tlucas, 2017/10/11 13:21:15]

Done.

 
 with addCommand(createDevEnv, 'devenv') as command:
     command.shortDescription = 'Set up a development environment'
     command.description = 'Will set up or update the devenv folder as an unpacked extension folder for development.'
     command.supportedTypes = ('gecko-webext', 'chrome')
 
 with addCommand(setupTranslations, 'setuptrans') as command:
     command.shortDescription = 'Sets up translation languages'
     command.description = 'Sets up translation languages for the project on crowdin.net.'
     command.params = '[options] project-key'
@@ skipping 59 matching lines @@
     elif len(types) > 1:
         print '''
 Ambiguous repository type, please specify -t parameter explicitly, e.g.
 %s -t %s build
 ''' % (scriptName, types[0])
         return None
     else:
         print '''
 No metadata file found in this repository, a metadata file like
 metadata.%s is required.
 ''' % knownTypes[0]

[kzar, 2017/10/10 13:45:59]

What about this, won't this fail?

[Sebastian Noack, 2017/10/10 18:34:28]

Well spotted, it would fail. I suggest to just change the messsage like this:

  No metadata file found in this repository, a metadata.* is required.

[tlucas, 2017/10/11 13:21:15]

Done.

         return None
 
 
 def processArgs(baseDir, args):
     global commands
 
     scriptName = os.path.basename(args[0])
     args = args[1:]
     type = getType(baseDir, scriptName, args)
     if type == None:
@@ skipping 20 matching lines @@
                 if option in ('-h', '--help'):
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)