Noissue - Use sets in build.py were appropriate

Noissue - Use sets in build.py were appropriate

[tlucas, 2017-10-10 13:01:55]

Patch Set 1

* Changed known type of to a set

[kzar, 2017-10-10 13:45:59]

https://codereview.adblockplus.org/29572671/diff/29572672/build.py
File build.py (right):

https://codereview.adblockplus.org/29572671/diff/29572672/build.py#newcode472
build.py:472: ''' % knownTypes[0]
What about this, won't this fail?

[Sebastian Noack, 2017-10-10 18:34:28]

https://codereview.adblockplus.org/29572671/diff/29572672/build.py
File build.py (right):

https://codereview.adblockplus.org/29572671/diff/29572672/build.py#newcode392
build.py:392: command.supportedTypes = ('gecko-webext', 'chrome', 'edge')
Can we please turn these into sets as well?

https://codereview.adblockplus.org/29572671/diff/29572672/build.py#newcode472
build.py:472: ''' % knownTypes[0]
On 2017/10/10 13:45:59, kzar wrote:
> What about this, won't this fail?

Well spotted, it would fail. I suggest to just change the messsage like this:

  No metadata file found in this repository, a metadata.* is required.

[tlucas, 2017-10-11 13:21:15]

Patch Set 2

 * Modified the description to be more meaningful
 * Got rid of all A102's (FTR, the initial knownTypes tuple didn't trigger this)
 * Converted supportedTyps in commands and types options to also be sets
 * Addressed potential error spotted by Dave

https://codereview.adblockplus.org/29572671/diff/29572672/build.py
File build.py (right):

https://codereview.adblockplus.org/29572671/diff/29572672/build.py#newcode392
build.py:392: command.supportedTypes = ('gecko-webext', 'chrome', 'edge')
On 2017/10/10 18:34:28, Sebastian Noack wrote:
> Can we please turn these into sets as well?

Done.

https://codereview.adblockplus.org/29572671/diff/29572672/build.py#newcode472
build.py:472: ''' % knownTypes[0]
On 2017/10/10 18:34:28, Sebastian Noack wrote:
> On 2017/10/10 13:45:59, kzar wrote:
> > What about this, won't this fail?
> 
> Well spotted, it would fail. I suggest to just change the messsage like this:
> 
>   No metadata file found in this repository, a metadata.* is required.
> 

Done.

https://codereview.adblockplus.org/29572671/diff/29573720/build.py
File build.py (right):

https://codereview.adblockplus.org/29572671/diff/29573720/build.py#newcode430
build.py:430: command.addOption('File containing private key and certificates
required to sign the release.', short='k', long='key', value='file',
types={'chrome', 'edge'})
These are handled in the same manner as supportedTypes for commands, i figured
changing them as well would be logical.

https://codereview.adblockplus.org/29572671/diff/29573720/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29572671/diff/29573720/tox.ini#newcode8
tox.ini:8: build.py : A104,A107,A201,A206,A302,E501,E711,N802,N803,N806
While at it, i got rid of the A102 too (see build.py)

[Sebastian Noack, 2017-10-11 18:45:58]

Nice, LGTM!

[kzar, 2017-10-13 12:32:08]

LGTM