Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29572692: Issue 5845 - Renaming gecko-webext to gecko (Closed)

Created:
Oct. 10, 2017, 1:14 p.m. by tlucas
Modified:
Oct. 11, 2017, 3:38 p.m.
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 5845 - Renaming gecko-webext to gecko

Patch Set 1 #

Patch Set 2 : NO CHANGE: rebasing against current master ( 492:08002782f3e3 ) #

Total comments: 1

Patch Set 3 : Removed another webext occurrence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build.py View 4 chunks +5 lines, -5 lines 0 comments Download
M packagerChrome.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M templates/manifest.json.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
tlucas
Patch Set 1 * Renamed "gecko-webext" to "gecko".
Oct. 10, 2017, 1:15 p.m. (2017-10-10 13:15:50 UTC) #1
Sebastian Noack
LGTM
Oct. 10, 2017, 4:22 p.m. (2017-10-10 16:22:57 UTC) #2
Vasily Kuznetsov
LGTM after you rebase it onto the last commit before landing, which I guess will ...
Oct. 11, 2017, 10:54 a.m. (2017-10-11 10:54:10 UTC) #3
tlucas
Patch Set 3 * Rebase against master * Renamed another newly introduced occurrence of "gecko-webext"
Oct. 11, 2017, 11:37 a.m. (2017-10-11 11:37:22 UTC) #4
kzar
Oct. 11, 2017, 1:36 p.m. (2017-10-11 13:36:42 UTC) #5
LGTM

https://codereview.adblockplus.org/29572692/diff/29573661/packagerChrome.py
File packagerChrome.py (right):

https://codereview.adblockplus.org/29572692/diff/29573661/packagerChrome.py#n...
packagerChrome.py:155: 'gecko-webext': 'geckoInfo.js.tmpl'
Heh, sorry about that one, but good catch.

Powered by Google App Engine
This is Rietveld