Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29572786: Issue 5842 - use specialization instead of translating the language (Closed)

Created:
Oct. 10, 2017, 5:19 p.m. by saroyanm
Modified:
Oct. 10, 2017, 5:38 p.m.
Reviewers:
Sebastian Noack
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 5842 - use specialization instead of translating the language

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -62 lines) Patch
M desktop-options.js View 3 chunks +7 lines, -2 lines 0 comments Download
M locale/en-US/desktop-options.json View 1 chunk +0 lines, -60 lines 1 comment Download

Messages

Total messages: 3
saroyanm
Sebastian can you please have a look.
Oct. 10, 2017, 5:23 p.m. (2017-10-10 17:23:48 UTC) #1
saroyanm
https://codereview.adblockplus.org/29572786/diff/29572790/locale/en-US/desktop-options.json File locale/en-US/desktop-options.json (left): https://codereview.adblockplus.org/29572786/diff/29572790/locale/en-US/desktop-options.json#oldcode450 locale/en-US/desktop-options.json:450: "options_language_en": { I removed English as well, but we ...
Oct. 10, 2017, 5:26 p.m. (2017-10-10 17:26:39 UTC) #2
Sebastian Noack
Oct. 10, 2017, 5:28 p.m. (2017-10-10 17:28:23 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld