Noissue - Drop support for flake8 2 from flake8-eyeo

flake8-eyeo/flake8_eyeo.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 335 matching lines @@
 
             keys.append(key)
 
     def visit_Dict(self, node):
         self._visit_hash_keys(node.keys, 'key in dict')
 
     def visit_Set(self, node):
         self._visit_hash_keys(node.elts, 'item in set')
 
 
-class ASTChecker(object):
-    def __init__(self, tree, filename):
-        self.tree = tree
+def check_ast(tree):

[Sebastian Noack, 2017/10/10 20:15:32]

This was merely a class because flake8 2 required AST checks to be implemented
as class, and token checks as function. With flake8 3 both can be either a
function or a class, and these 4 lines hardly justify a class.

+    visitor = TreeVisitor()
+    visitor.visit(tree)
 
-    def run(self):
-        visitor = TreeVisitor()
-        visitor.visit(self.tree)
-
-        for node, error in visitor.errors:
-            yield (node.lineno, node.col_offset, error, type(self))
+    for node, error in visitor.errors:
+        yield (node.lineno, node.col_offset, error, None)

[Sebastian Noack, 2017/10/10 20:15:32]

The forth argument is obsolete and unused. However, flake8 still expects us to
yield 4 items for backwards compatibility.

 
 
 def check_non_default_encoding(physical_line, line_number):
     if line_number <= 2 and re.search(r'^\s*#.*coding[:=]', physical_line):
         return (0, 'A303 non-default file encoding')
 
 
 def check_quotes(logical_line, tokens, previous_logical, checker_state):
     first_token = True
 
@@ skipping 88 matching lines @@
                     # outer parenthesis closed before end of expression
                     if tokens[i + 1][:2] != (tokenize.OP, ':'):
                         break
 
                     return [(pos, 'A111 redundant parenthesis for {} '
                                   'statement'.format(statement))]
 
     return []
 
 
-for checker in [ASTChecker, check_non_default_encoding,
+for checker in [check_ast, check_non_default_encoding,
                 check_quotes, check_redundant_parenthesis]:
     checker.name = 'eyeo'
     checker.version = __version__