Noissue - Drop support for flake8 2 from flake8-eyeo

Noissue - Drop support for flake8 2 from flake8-eyeo

[Sebastian Noack, 2017-10-10 20:15:32]

https://codereview.adblockplus.org/29573036/diff/29573037/flake8-eyeo/flake8_...
File flake8-eyeo/flake8_eyeo.py (right):

https://codereview.adblockplus.org/29573036/diff/29573037/flake8-eyeo/flake8_...
flake8-eyeo/flake8_eyeo.py:356: def check_ast(tree):
This was merely a class because flake8 2 required AST checks to be implemented
as class, and token checks as function. With flake8 3 both can be either a
function or a class, and these 4 lines hardly justify a class.

https://codereview.adblockplus.org/29573036/diff/29573037/flake8-eyeo/flake8_...
flake8-eyeo/flake8_eyeo.py:361: yield (node.lineno, node.col_offset, error,
None)
The forth argument is obsolete and unused. However, flake8 still expects us to
yield 4 items for backwards compatibility.

https://codereview.adblockplus.org/29573036/diff/29573037/flake8-eyeo/setup.py
File flake8-eyeo/setup.py (right):

https://codereview.adblockplus.org/29573036/diff/29573037/flake8-eyeo/setup.p...
flake8-eyeo/setup.py:105: install_requires=['flake8>=3.2.1'],
This is the oldest version for flake8>2, that flake8-eyeo is currently
compatible with. For flake8>2,<3.2.1, we'd need to register the extension in a
different way, which however is incompatible with flake8>3.4.0, as explained in
the recent review that fixed compatibility.

[Vasily Kuznetsov, 2017-10-11 19:47:53]

LGTM