Unified Diff: desktop-options.html
Issue 29573041:
Issue 5850 - Social media links are broken (Closed)
Patch Set:
Created Oct. 10, 2017, 8:12 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.html |
| =================================================================== |
| --- a/desktop-options.html |
| +++ b/desktop-options.html |
| @@ -309,12 +309,12 @@ |
| </header> |
| <div id="social"> |
| <ul id="social-general"> |
| - <li><a id="twitter">Twitter</a></li> |
| - <li><a id="facebook">Facebook</a></li> |
| - <li><a id="google-plus">Google Plus</a></li> |
| + <li><a id="twitter" target="_blank">Twitter</a></li> |
|
saroyanm
2017/10/10 20:15:10
I decided to use target="_blank" instead of target
ire
2017/10/11 09:18:34
Ack. I think this was the right decision.
|
| + <li><a id="facebook" target="_blank">Facebook</a></li> |
| + <li><a id="google-plus" target="_blank">Google Plus</a></li> |
| </ul> |
| <ul id="social-chinese"> |
| - <li><a id="weibo">Weibo</a></li> |
| + <li><a id="weibo" target="_blank">Weibo</a></li> |
| </ul> |
| <p> |
| <strong> |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
