Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 29573134: Issue 5028 - Use browser namespace (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Manish Jethani
Modified:
2 years, 1 month ago
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/buildtools/
Visibility:
Public.

Description

Issue 5028 - Use browser namespace Related: https://codereview.adblockplus.org/29570614/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove change from geckoInfo.js.tmpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromeDevenvPoller__.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
2 years, 1 month ago (2017-10-10 22:53:46 UTC) #1
Manish Jethani
Patch Set 1
2 years, 1 month ago (2017-10-10 22:55:05 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29573134/diff/29573135/templates/geckoInfo.js.tmpl File templates/geckoInfo.js.tmpl (right): https://codereview.adblockplus.org/29573134/diff/29573135/templates/geckoInfo.js.tmpl#newcode23 templates/geckoInfo.js.tmpl:23: browser.runtime.getBrowserInfo(browserInfo => This shouldn't be necessary. I think, we ...
2 years, 1 month ago (2017-10-10 23:12:19 UTC) #3
Manish Jethani
Patch Set 2: Remove change from geckoInfo.js.tmpl https://codereview.adblockplus.org/29573134/diff/29573135/templates/geckoInfo.js.tmpl File templates/geckoInfo.js.tmpl (right): https://codereview.adblockplus.org/29573134/diff/29573135/templates/geckoInfo.js.tmpl#newcode23 templates/geckoInfo.js.tmpl:23: browser.runtime.getBrowserInfo(browserInfo => ...
2 years, 1 month ago (2017-10-11 11:33:27 UTC) #4
Sebastian Noack
2 years, 1 month ago (2017-10-13 02:50:21 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5