Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/geckoInfo.js.tmpl

Issue 29573134: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/buildtools/
Patch Set: Created Oct. 10, 2017, 10:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeDevenvPoller__.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/geckoInfo.js.tmpl
===================================================================
--- a/templates/geckoInfo.js.tmpl
+++ b/templates/geckoInfo.js.tmpl
@@ -15,17 +15,17 @@
let match = /\brv:(\d+(?:\.\d+)?)\b/.exec(navigator.userAgent);
if (match)
exports.platformVersion = match[1];
// Firefox 50 does not support runtime.getBrowserInfo
if ("getBrowserInfo" in browser.runtime)
{
- browser.runtime.getBrowserInfo().then(browserInfo =>
+ browser.runtime.getBrowserInfo(browserInfo =>
Sebastian Noack 2017/10/10 23:12:19 This shouldn't be necessary. I think, we should no
Manish Jethani 2017/10/11 11:33:27 Done.
{
exports.application = browserInfo.name.toLowerCase();
exports.applicationVersion = browserInfo.version;
});
}
else
{
let browserInfo = /\bFirefox\/(\S+)/.exec(navigator.userAgent);
« no previous file with comments | « chromeDevenvPoller__.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld