Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29573726: Issue 4580 - Replace ext.backgroundPage.sendMessage with runtime.sendMessage (Closed)

Created:
Oct. 11, 2017, 2:54 p.m. by Manish Jethani
Modified:
Oct. 13, 2017, 7:53 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 4580 - Replace ext.backgroundPage.sendMessage with runtime.sendMessage Related: https://codereview.adblockplus.org/29573735/

Patch Set 1 #

Patch Set 2 : Update dependency #

Total comments: 2

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -30 lines) Patch
M composer.js View 1 chunk +2 lines, -2 lines 0 comments Download
M composer.postload.js View 5 chunks +8 lines, -8 lines 0 comments Download
M desktop-options.js View 2 chunks +5 lines, -5 lines 0 comments Download
M ext/common.js View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M include.preload.js View 4 chunks +6 lines, -6 lines 0 comments Download
M inject.preload.js View 1 chunk +1 line, -1 line 0 comments Download
M subscriptionLink.postload.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Manish Jethani
Oct. 11, 2017, 2:54 p.m. (2017-10-11 14:54:11 UTC) #1
Manish Jethani
Patch Set 1
Oct. 11, 2017, 3:39 p.m. (2017-10-11 15:39:45 UTC) #2
Manish Jethani
Patch Set 2: Update dependency
Oct. 11, 2017, 4:56 p.m. (2017-10-11 16:56:43 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29573726/diff/29573808/ext/common.js File ext/common.js (left): https://codereview.adblockplus.org/29573726/diff/29573808/ext/common.js#oldcode74 ext/common.js:74: ext.backgroundPage = { I guess this needs to be ...
Oct. 13, 2017, 2:52 a.m. (2017-10-13 02:52:19 UTC) #4
Manish Jethani
Patch Set 3: Rebase https://codereview.adblockplus.org/29573726/diff/29573808/ext/common.js File ext/common.js (left): https://codereview.adblockplus.org/29573726/diff/29573808/ext/common.js#oldcode74 ext/common.js:74: ext.backgroundPage = { On 2017/10/13 ...
Oct. 13, 2017, 5:08 a.m. (2017-10-13 05:08:41 UTC) #5
Sebastian Noack
Oct. 13, 2017, 7:33 p.m. (2017-10-13 19:33:49 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld