ext/common.js - Issue 29573726: Issue 4580 - Replace ext.backgroundPage.sendMessage with runtime.sendMessage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/common.js

Issue 29573726: Issue 4580 - Replace ext.backgroundPage.sendMessage with runtime.sendMessage (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Update dependency Created Oct. 11, 2017, 4:56 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ext/common.js

===================================================================

--- a/ext/common.js

+++ b/ext/common.js

@@ -67,17 +67,16 @@

/* Message passing */

ext.onMessage = new ext._EventTarget();

/* Background page */

ext.backgroundPage = {

Sebastian Noack 2017/10/13 02:52:18 I guess this needs to be rebased, and we can get r

Manish Jethani 2017/10/13 05:08:41 Done.

- sendMessage: chrome.runtime.sendMessage,

getWindow()

{

return chrome.extension.getBackgroundPage();

}

};

/* Utils */

« no previous file with comments | « desktop-options.js ('k') | include.preload.js » ('j') | no next file with comments »