Issue 29573871: Noissue - Refactored website-default scss comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29573871: Noissue - Refactored website-default scss comments (Closed)

Created:
Oct. 11, 2017, 6:35 p.m. by juliandoucette

Modified:
Oct. 12, 2017, noon

Reviewers:
ire

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Description

Noissue - Refactored website-default scss comments

Patch Set 1 #

Total comments: 3

Created: Oct. 11, 2017, 6:35 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -161 lines)			Patch
M	scss/_base.scss	View	1 chunk	+15 lines, -17 lines	0 comments	Download
M	scss/_content.scss	View	1 chunk	+15 lines, -17 lines	0 comments	Download
M	scss/_grid.scss	View	1 chunk	+15 lines, -17 lines	0 comments	Download
M	scss/_reset.scss	View	1 chunk	+15 lines, -17 lines	0 comments	Download
M	scss/_variables.scss	View	1 chunk	+40 lines, -42 lines	0 comments	Download
M	scss/forms/_advanced.scss	View	1 chunk	+15 lines, -17 lines	1 comment	Download
M	scss/forms/_basic.scss	View	1 chunk	+15 lines, -17 lines	1 comment	Download
M	scss/forms/_buttons.scss	View	1 chunk	+15 lines, -17 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ire

LGTM. One request below.. https://codereview.adblockplus.org/29573871/diff/29573872/scss/forms/_advanced.scss File scss/forms/_advanced.scss (right): https://codereview.adblockplus.org/29573871/diff/29573872/scss/forms/_advanced.scss#newcode20 scss/forms/_advanced.scss:20: * 1. Reset Noticed there ...

Oct. 12, 2017, 10:42 a.m. (2017-10-12 10:42:50 UTC) #2

juliandoucette

On 2017/10/12 10:42:50, ire wrote: > Noticed there are two Reset headings here (definitely my ...

Oct. 12, 2017, 11:58 a.m. (2017-10-12 11:58:34 UTC) #3

juliandoucette

Oct. 12, 2017, noon (2017-10-12 12:00:23 UTC) #4

https://hg.adblockplus.org/website-defaults/rev/0a082652f5d7

Expand All Messages | Collapse All Messages