Issue 29573895: Issue 5160 - Alias new class names and properties.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29573895: Issue 5160 - Alias new class names and properties. (Closed)

Created:
Oct. 11, 2017, 7:38 p.m. by hub

Modified:
Oct. 13, 2017, 12:35 p.m.

Reviewers:
sergei, Wladimir Palant

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 5160 - Alias new class names and properties.

Patch Set 1 #

Total comments: 2

Created: Oct. 11, 2017, 7:38 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -8 lines)			Patch
M	compiled/bindings/main.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	lib/subscriptionClasses.js	View	2 chunks	+36 lines, -2 lines	1 comment	Download
M	test/subscriptionClasses.js	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hub

I'd see the aliases being removed sooner rather than later. https://codereview.adblockplus.org/29573895/diff/29573896/lib/subscriptionClasses.js File lib/subscriptionClasses.js (right): https://codereview.adblockplus.org/29573895/diff/29573896/lib/subscriptionClasses.js#newcode55 ...

Oct. 11, 2017, 7:42 p.m. (2017-10-11 19:42:02 UTC) #2

LGTM

Expand All Messages | Collapse All Messages