Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29573922: Issue 5837 - Updated buildtools and adblockplusui dependencies for locale changes (Closed)

Created:
Oct. 11, 2017, 11:39 p.m. by Sebastian Noack
Modified:
Oct. 12, 2017, 12:01 a.m.
Reviewers:
tlucas
CC:
kzar
Visibility:
Public.

Description

Issue 5837 - Updated buildtools and adblockplusui dependencies for locale changes

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M _locales/es_MX/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M _locales/es_MX/store.description View 0 chunks +-1 lines, --1 lines 0 comments Download
M dependencies View 1 chunk +2 lines, -2 lines 0 comments Download
M ensure_dependencies.py View 2 chunks +2 lines, -0 lines 0 comments Download
M metadata.chrome View 1 chunk +2 lines, -2 lines 0 comments Download
M metadata.gecko View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
Oct. 11, 2017, 11:39 p.m. (2017-10-11 23:39:42 UTC) #1
tlucas
Only a nit: The ticket says 'es-419' should be renamed to 'es-MX' - but here ...
Oct. 11, 2017, 11:57 p.m. (2017-10-11 23:57:25 UTC) #2
Sebastian Noack
Oct. 11, 2017, 11:59 p.m. (2017-10-11 23:59:04 UTC) #3
On 2017/10/11 23:57:25, tlucas wrote:
> Only a nit:
> The ticket says 'es-419' should be renamed to 'es-MX' - but here it is
'es_MX'.
> I know that the latter is correct though

Well spotted. I updated the issue description.

Powered by Google App Engine
This is Rietveld